commit 8cb33e0c38fd5250934b473726878cb64fe2f1fe
author dschinazi <dschinazi@google.com> Thu Apr 02 16:25:09 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 02 16:25:36 2020 -0700
tree 827a8e5a8613d39547bf2ee4ac2e256fab89f6c0
parent badbe92c7bcae2d48bc2d15d796a6fea3638dc0f

Improve logs with stream IDs

This CL improves our logging to facilitate debugging of test failures.

gfe-relnote: n/a, log-only
PiperOrigin-RevId: 304500766
Change-Id: I29ec300881e9c7b9b43f6f6e0892ee685d8df253

quic/core/quic_session.cc

diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index 5376bfd..bd29b8e 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -1477,7 +1477,7 @@
   QuicStreamId stream_id = stream->id();
   bool is_static = stream->is_static();
   QUIC_DVLOG(1) << ENDPOINT << "num_streams: " << stream_map_.size()
-                << ". activating " << stream_id;
+                << ". activating stream " << stream_id;
   DCHECK(!QuicContainsKey(stream_map_, stream_id));
   stream_map_[stream_id] = std::move(stream);
   if (IsIncomingStream(stream_id)) {

quic/core/quic_write_blocked_list.h

diff --git a/quic/core/quic_write_blocked_list.h b/quic/core/quic_write_blocked_list.h
index c987112..333aaff 100644
--- a/quic/core/quic_write_blocked_list.h
+++ b/quic/core/quic_write_blocked_list.h
@@ -145,7 +145,8 @@
   void RegisterStream(QuicStreamId stream_id,
                       bool is_static_stream,
                       const spdy::SpdyStreamPrecedence& precedence) {
-    DCHECK(!priority_write_scheduler_->StreamRegistered(stream_id));
+    DCHECK(!priority_write_scheduler_->StreamRegistered(stream_id))
+        << "stream " << stream_id << " already registered";
     DCHECK(PrecedenceMatchesSchedulerType(precedence));
     if (is_static_stream) {
       static_stream_collection_.Register(stream_id);