| commit | 85f18900f41d65dfe417a549703bd4b46289bed3 | [log] [tgz] |
|---|---|---|
| author | fkastenholz <fkastenholz@google.com> | Tue May 28 12:47:00 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed May 29 13:09:21 2019 -0700 |
| tree | 454acaede75a2caada4830ba369bef06535ad341 | |
| parent | 0220865bffc15469c7e76ec9a1c573bcf395afab [diff] |
QuicConnection methods call CloseConnection rather than TearDownLocalConnectionState Some of the QuicConnection methods call TearDownLocalConnectionState rather than CloseConnection. This changes then all to call CloseConnection, specifying ConnectionCloseBehavior::SILENT_CLOSE. Some tests modified to expect calls to CloseConnection (preventing test failure due to unexpected calls). Before this CL the connection closing happened via internal calls directly to TearDownLocalConnectionState; now these calls go through CloseConnection and trigger the expect. This is done in preparation for landing another CL adding IETF QUIC Connection Close functionality. QuicConnection::OnUnrecoverableError (which is an override of QuicPacketCreator::OnUnrecoverableError) called TearDownLocalConnectionState. It had to be modified to call CloseConnection. OnUnrecoverableError has a ConnectionCloseSource parameter, which CloseConnection does not take. Thus the parameter was removed from OnUnrecoverableError. This is OK since all of the calls to OnUnrecoverableError specified FROM_SELF as the source. CloseConnection uses FROM_SELF as the source (unless the error code is a stateless reject or public reset). gfe-relnote: No flag protection as it is only moving existing functionality around. PiperOrigin-RevId: 250341745 Change-Id: Iafe499eda682f3db678d0eddbf7e2e3e4367cebd
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects.
The code is currently in process of being moved from https://cs.chromium.org/chromium/src/net/third_party/ into this repository. Please excuse our appearance while we're under construction.