| commit | 60cef586e82d09bf2037667598ae845d9e9ba10b | [log] [tgz] |
|---|---|---|
| author | bnc <bnc@google.com> | Wed Mar 24 10:25:37 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Mar 24 10:26:21 2021 -0700 |
| tree | 84aac8b110a6fb2fbf94397f0237849abb4c6a29 | |
| parent | 600fdf9b6b54c852c9bf0821e149bc38f01ce367 [diff] |
Remove SpdyStrAppend, SpdyHexEncodeUInt32AndTrim, SpdyStringPieceCaseHash, and SpdyStringPieceCaseEq from spdy/platform. SpdyStrAppend and SpdyHexEncodeUInt32AndTrim can now be inlined, and call sites simplified to avoid nested StrCat/StrAppend. Also change some stray std::string::append(StrCat) to StrAppend. SpdyStringPieceCaseHash and SpdyStringPieceCaseEq have such simple implementations that it is not worth to platformize them, especially given that only the internal implementation can delegate to an existing library (internal-only, see b/157743370), Chromium and Envoy both have to implement them: https://source.chromium.org/chromium/chromium/src/+/master:net/spdy/platform/impl/spdy_string_utils_impl.h https://github.com/envoyproxy/envoy/blob/1d1b708c7bf6efa02c41d9ce22cbf1e4a1aeec2c/source/extensions/quic_listeners/quiche/platform/spdy_string_utils_impl.h#L52-L63 PiperOrigin-RevId: 364834100 Change-Id: I70f95182b3fd7e97b19248de4512cea443a3ffdb
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects. QUICHE is only supported on little-endian platforms.
Code can be viewed in CodeSearch in Quiche and is imported into Chromium.