commit 83f29bd6fa2ba49ede3b15b7623bb81d455fe20e
author rch <rch@google.com> Wed Nov 13 11:47:34 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Nov 13 11:48:12 2019 -0800
tree 35fac3c19be02f4be0534ff1faa1b2d5d6c4f7a5
parent 20df1afcd3ebed480369165baf1629d72a80e573

Change CryptoServerConfigForTesting to return a unique_ptr
instead of an object because CryptoServerConfigForTesting has
now copy constructor.

gfe-relnote: n/a - Test only
PiperOrigin-RevId: 280245335
Change-Id: Ie66e8c170211f291e1ff146c6b156dfd6b7685e9

quic/core/quic_crypto_client_stream_test.cc

diff --git a/quic/core/quic_crypto_client_stream_test.cc b/quic/core/quic_crypto_client_stream_test.cc
index 4fd338f..9e957e4 100644
--- a/quic/core/quic_crypto_client_stream_test.cc
+++ b/quic/core/quic_crypto_client_stream_test.cc
@@ -82,7 +82,7 @@
     stream()->CryptoConnect();
     QuicConfig config;
     crypto_test_utils::HandshakeWithFakeServer(
-        &config, &server_crypto_config_, &server_helper_, &alarm_factory_,
+        &config, server_crypto_config_.get(), &server_helper_, &alarm_factory_,
         connection_, stream(), AlpnForVersion(connection_->version()));
   }
 
@@ -99,7 +99,7 @@
   QuicServerId server_id_;
   CryptoHandshakeMessage message_;
   QuicCryptoClientConfig crypto_config_;
-  QuicCryptoServerConfig server_crypto_config_;
+  std::unique_ptr<QuicCryptoServerConfig> server_crypto_config_;
 };
 
 TEST_F(QuicCryptoClientStreamTest, NotInitiallyConected) {
@@ -133,7 +133,7 @@
   stream()->CryptoConnect();
   QuicConfig config;
   crypto_test_utils::HandshakeWithFakeServer(
-      &config, &server_crypto_config_, &server_helper_, &alarm_factory_,
+      &config, server_crypto_config_.get(), &server_helper_, &alarm_factory_,
       connection_, stream(), AlpnForVersion(connection_->version()));
   EXPECT_EQ(PROTOCOL_TLS1_3, stream()->handshake_protocol());
   EXPECT_TRUE(stream()->encryption_established());
@@ -143,7 +143,7 @@
 TEST_F(QuicCryptoClientStreamTest, TlsResumption) {
   UseTlsHandshake();
   // Enable resumption on the server:
-  SSL_CTX_clear_options(server_crypto_config_.ssl_ctx(), SSL_OP_NO_TICKET);
+  SSL_CTX_clear_options(server_crypto_config_->ssl_ctx(), SSL_OP_NO_TICKET);
   CreateConnection();
 
   // Finish establishing the first connection: