gfe-relnote: rename OnConnectivityProbeReceived to OnPacketReceived.
Not flag protected, this is a refactor and has no behavior change.
Currently OnConnectivityProbeReceived is called in two cases:
1. notify the server that a "connectivity probe packet" is received
2. notify the client that a "general packet" is received.
The name of the function is not correct in seconds case. This change
renames the method to OnPacketReceived with an additional parameter
passed to indicate whether the packet is a connectivity probe.
PiperOrigin-RevId: 264168409
Change-Id: I49cd3bc173e1ede3a3b72dc106380769ad50721b
diff --git a/quic/test_tools/quic_test_utils.h b/quic/test_tools/quic_test_utils.h
index 84374ea..40b8036 100644
--- a/quic/test_tools/quic_test_utils.h
+++ b/quic/test_tools/quic_test_utils.h
@@ -382,9 +382,10 @@
MOCK_CONST_METHOD0(ShouldKeepConnectionAlive, bool());
MOCK_METHOD1(OnSuccessfulVersionNegotiation,
void(const ParsedQuicVersion& version));
- MOCK_METHOD2(OnConnectivityProbeReceived,
+ MOCK_METHOD3(OnPacketReceived,
void(const QuicSocketAddress& self_address,
- const QuicSocketAddress& peer_address));
+ const QuicSocketAddress& peer_address,
+ bool is_connectivity_probe));
MOCK_METHOD0(OnConfigNegotiated, void());
MOCK_METHOD0(OnAckNeedsRetransmittableFrame, void());
MOCK_METHOD0(SendPing, void());
diff --git a/quic/test_tools/simulator/quic_endpoint.h b/quic/test_tools/simulator/quic_endpoint.h
index 7481ddc..43fce53 100644
--- a/quic/test_tools/simulator/quic_endpoint.h
+++ b/quic/test_tools/simulator/quic_endpoint.h
@@ -97,9 +97,9 @@
void OnWriteBlocked() override {}
void OnSuccessfulVersionNegotiation(
const ParsedQuicVersion& /*version*/) override {}
- void OnConnectivityProbeReceived(
- const QuicSocketAddress& /*self_address*/,
- const QuicSocketAddress& /*peer_address*/) override {}
+ void OnPacketReceived(const QuicSocketAddress& /*self_address*/,
+ const QuicSocketAddress& /*peer_address*/,
+ bool /*is_connectivity_probe*/) override {}
void OnCongestionWindowChange(QuicTime /*now*/) override {}
void OnConnectionMigration(AddressChangeType /*type*/) override {}
void OnPathDegrading() override {}
