commit 81e779db54d3d1543e5923112b0dd42253c222c4
author QUICHE team <quiche-dev@google.com> Thu Apr 15 16:09:56 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 15 16:10:37 2021 -0700
tree 1f49c8972cdb3ca4a8aa33318ac0302726676063
parent 313870e211760d5f5e4bcec38c5b29e4ca4ed35b

Moves EXPECT_SPDY_BUG into Quiche as EXPECT_QUICHE_BUG.

There are no Chromium references to EXPECT_SPDY_BUG outside of the code imported from Quiche and the one line platform implementation.
  https://source.chromium.org/chromium/chromium/src/+/master:net/spdy/platform/impl/spdy_test_helpers_impl.h

PiperOrigin-RevId: 368737375
Change-Id: If1ae8022d694b2a28e33a2a48ccadd54b9b93f4f

http2/adapter/oghttp2_adapter_test.cc

diff --git a/http2/adapter/oghttp2_adapter_test.cc b/http2/adapter/oghttp2_adapter_test.cc
index 436fb2e..fef15aa 100644
--- a/http2/adapter/oghttp2_adapter_test.cc
+++ b/http2/adapter/oghttp2_adapter_test.cc
@@ -3,7 +3,7 @@
 #include "http2/adapter/mock_http2_visitor.h"
 #include "http2/adapter/test_utils.h"
 #include "common/platform/api/quiche_test.h"
-#include "spdy/platform/api/spdy_test_helpers.h"
+#include "common/platform/api/quiche_test_helpers.h"
 
 namespace http2 {
 namespace adapter {
@@ -22,23 +22,23 @@
 };
 
 TEST_F(OgHttp2AdapterTest, ProcessBytes) {
-  EXPECT_SPDY_BUG(adapter_->ProcessBytes("fake data"), "Not implemented");
+  EXPECT_QUICHE_BUG(adapter_->ProcessBytes("fake data"), "Not implemented");
 }
 
 TEST_F(OgHttp2AdapterTest, SubmitMetadata) {
-  EXPECT_SPDY_BUG(adapter_->SubmitMetadata(3, true), "Not implemented");
+  EXPECT_QUICHE_BUG(adapter_->SubmitMetadata(3, true), "Not implemented");
 }
 
 TEST_F(OgHttp2AdapterTest, GetPeerConnectionWindow) {
   int peer_window = 0;
-  EXPECT_SPDY_BUG(peer_window = adapter_->GetPeerConnectionWindow(),
-                  "Not implemented");
+  EXPECT_QUICHE_BUG(peer_window = adapter_->GetPeerConnectionWindow(),
+                    "Not implemented");
   EXPECT_GT(peer_window, 0);
 }
 
 TEST_F(OgHttp2AdapterTest, MarkDataConsumedForStream) {
-  EXPECT_SPDY_BUG(adapter_->MarkDataConsumedForStream(1, 11),
-                  "Stream 1 not found");
+  EXPECT_QUICHE_BUG(adapter_->MarkDataConsumedForStream(1, 11),
+                    "Stream 1 not found");
 }
 
 TEST_F(OgHttp2AdapterTest, TestSerialize) {

http2/adapter/window_manager_test.cc

diff --git a/http2/adapter/window_manager_test.cc b/http2/adapter/window_manager_test.cc
index 549fd1c..5e06453 100644
--- a/http2/adapter/window_manager_test.cc
+++ b/http2/adapter/window_manager_test.cc
@@ -5,7 +5,7 @@
 #include "absl/functional/bind_front.h"
 #include "http2/test_tools/http2_random.h"
 #include "common/platform/api/quiche_test.h"
-#include "spdy/platform/api/spdy_test_helpers.h"
+#include "common/platform/api/quiche_test_helpers.h"
 
 namespace http2 {
 namespace adapter {
@@ -97,13 +97,13 @@
 TEST_F(WindowManagerTest, AvoidBufferedUnderflow) {
   EXPECT_EQ(peer_.buffered(), 0);
   // Don't flush more than has been buffered!
-  EXPECT_SPDY_BUG(wm_.MarkDataFlushed(1), "buffered underflow");
+  EXPECT_QUICHE_BUG(wm_.MarkDataFlushed(1), "buffered underflow");
   EXPECT_EQ(peer_.buffered(), 0);
 
   wm_.MarkDataBuffered(42);
   EXPECT_EQ(peer_.buffered(), 42);
   // Don't flush more than has been buffered!
-  EXPECT_SPDY_BUG(wm_.MarkDataFlushed(43), "buffered underflow");
+  EXPECT_QUICHE_BUG(wm_.MarkDataFlushed(43), "buffered underflow");
   EXPECT_EQ(peer_.buffered(), 0);
 }