commit 7685542ecb4a39ed154b08754e59cbcc84aef7fb
author wub <wub@google.com> Thu Oct 24 08:53:04 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Oct 24 08:53:39 2019 -0700
tree 240a5981564255996b60df9a4bb7c3797e15f8f7
parent 0b2ae54bded0684d766b74b23f837e1f106b1f8a

Fix 10 ClangTidy - Performance findings in //depot/google3/third_party/quic/.

These fixes are automatically created by various analysis tools, but their application in this CL has been manually triggered.  See go/code-findings-fixes.

* passing result of std::move() as a const reference argument; no move will actually happen (4 times)
* use absl::StartsWith instead of find() == 0
* use ZeroDuration() for zero-length time intervals (5 times)

PiperOrigin-RevId: 276497039
Change-Id: Ic5461dfa0fee864263437bafa7d4a137e2b44f25

quic/test_tools/crypto_test_utils.cc

diff --git a/quic/test_tools/crypto_test_utils.cc b/quic/test_tools/crypto_test_utils.cc
index 98d65e8..f38ea81 100644
--- a/quic/test_tools/crypto_test_utils.cc
+++ b/quic/test_tools/crypto_test_utils.cc
@@ -782,7 +782,7 @@
       QuicRandom::GetInstance(), clock, new_config_options);
   primary_config.set_primary_time(clock->WallNow().ToUNIXSeconds());
   std::unique_ptr<CryptoHandshakeMessage> msg =
-      crypto_config->AddConfig(std::move(primary_config), clock->WallNow());
+      crypto_config->AddConfig(primary_config, clock->WallNow());
   QuicStringPiece orbit;
   CHECK(msg->GetStringPiece(kORBT, &orbit));
   std::string nonce;