commit 7685542ecb4a39ed154b08754e59cbcc84aef7fb
author wub <wub@google.com> Thu Oct 24 08:53:04 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Oct 24 08:53:39 2019 -0700
tree 240a5981564255996b60df9a4bb7c3797e15f8f7
parent 0b2ae54bded0684d766b74b23f837e1f106b1f8a

Fix 10 ClangTidy - Performance findings in //depot/google3/third_party/quic/.

These fixes are automatically created by various analysis tools, but their application in this CL has been manually triggered.  See go/code-findings-fixes.

* passing result of std::move() as a const reference argument; no move will actually happen (4 times)
* use absl::StartsWith instead of find() == 0
* use ZeroDuration() for zero-length time intervals (5 times)

PiperOrigin-RevId: 276497039
Change-Id: Ic5461dfa0fee864263437bafa7d4a137e2b44f25

quic/qbone/bonnet/icmp_reachable_test.cc

diff --git a/quic/qbone/bonnet/icmp_reachable_test.cc b/quic/qbone/bonnet/icmp_reachable_test.cc
index 303f0e2..99de19c 100644
--- a/quic/qbone/bonnet/icmp_reachable_test.cc
+++ b/quic/qbone/bonnet/icmp_reachable_test.cc
@@ -118,7 +118,7 @@
 };
 
 TEST_F(IcmpReachableTest, SendsPings) {
-  IcmpReachable reachable(source_, destination_, absl::Seconds(0), &kernel_,
+  IcmpReachable reachable(source_, destination_, absl::ZeroDuration(), &kernel_,
                           &epoll_server_, &stats_);
 
   SetFdExpectations();
@@ -140,7 +140,7 @@
 }
 
 TEST_F(IcmpReachableTest, HandlesUnreachableEvents) {
-  IcmpReachable reachable(source_, destination_, absl::Seconds(0), &kernel_,
+  IcmpReachable reachable(source_, destination_, absl::ZeroDuration(), &kernel_,
                           &epoll_server_, &stats_);
 
   SetFdExpectations();
@@ -164,7 +164,7 @@
 }
 
 TEST_F(IcmpReachableTest, HandlesReachableEvents) {
-  IcmpReachable reachable(source_, destination_, absl::Seconds(0), &kernel_,
+  IcmpReachable reachable(source_, destination_, absl::ZeroDuration(), &kernel_,
                           &epoll_server_, &stats_);
 
   SetFdExpectations();
@@ -212,7 +212,7 @@
 }
 
 TEST_F(IcmpReachableTest, HandlesWriteErrors) {
-  IcmpReachable reachable(source_, destination_, absl::Seconds(0), &kernel_,
+  IcmpReachable reachable(source_, destination_, absl::ZeroDuration(), &kernel_,
                           &epoll_server_, &stats_);
 
   SetFdExpectations();
@@ -232,7 +232,7 @@
 }
 
 TEST_F(IcmpReachableTest, HandlesReadErrors) {
-  IcmpReachable reachable(source_, destination_, absl::Seconds(0), &kernel_,
+  IcmpReachable reachable(source_, destination_, absl::ZeroDuration(), &kernel_,
                           &epoll_server_, &stats_);
 
   SetFdExpectations();