commit 7611d4235a96aecbaaf5f4b937bd29beb90ca5cb
author rch <rch@google.com> Mon Dec 08 16:09:29 2025 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Dec 08 16:10:39 2025 -0800
tree f4729655b5d6a39e5a9f0da87a52b41e133ce82f
parent 2c546d597476c912b1c71222a64fb03feb274381

Remove unused HandshakeProtocol type.

PiperOrigin-RevId: 841952377

quiche/quic/core/quic_versions.cc

diff --git a/quiche/quic/core/quic_versions.cc b/quiche/quic/core/quic_versions.cc
index ae883c3..7f718b8 100644
--- a/quiche/quic/core/quic_versions.cc
+++ b/quiche/quic/core/quic_versions.cc
@@ -433,16 +433,6 @@
                       static_cast<int>(transport_version), ")");
 }
 
-std::string HandshakeProtocolToString(HandshakeProtocol handshake_protocol) {
-  switch (handshake_protocol) {
-    RETURN_STRING_LITERAL(PROTOCOL_UNSUPPORTED);
-    RETURN_STRING_LITERAL(PROTOCOL_QUIC_CRYPTO);
-    RETURN_STRING_LITERAL(PROTOCOL_TLS1_3);
-  }
-  return absl::StrCat("PROTOCOL_UNKNOWN(", static_cast<int>(handshake_protocol),
-                      ")");
-}
-
 std::string ParsedQuicVersionToString(ParsedQuicVersion version) {
   static_assert(SupportedVersions().size() == 4u,
                 "Supported versions out of sync");

quiche/quic/core/quic_versions.h

diff --git a/quiche/quic/core/quic_versions.h b/quiche/quic/core/quic_versions.h
index b2bce99..6f868ab 100644
--- a/quiche/quic/core/quic_versions.h
+++ b/quiche/quic/core/quic_versions.h
@@ -147,19 +147,6 @@
 QUICHE_EXPORT std::string QuicVersionToString(
     QuicTransportVersion transport_version);
 
-// The crypto handshake protocols that can be used with QUIC.
-// We are planning on eventually deprecating PROTOCOL_QUIC_CRYPTO in favor of
-// PROTOCOL_TLS1_3.
-enum HandshakeProtocol {
-  PROTOCOL_UNSUPPORTED = 0,
-  PROTOCOL_QUIC_CRYPTO = 1,
-  PROTOCOL_TLS1_3 = 2,
-};
-
-// Helper function which translates from a HandshakeProtocol to a string.
-QUICHE_EXPORT std::string HandshakeProtocolToString(
-    HandshakeProtocol handshake_protocol);
-
 // Returns whether this version is documented by an IETF internet-draft or RFC.
 QUICHE_EXPORT constexpr bool VersionIsIetfQuic(
     QuicTransportVersion transport_version) {
@@ -184,17 +171,6 @@
   return false;
 }
 
-QUICHE_EXPORT constexpr HandshakeProtocol HandshakeProtocolForTransportVersion(
-    QuicTransportVersion transport_version) {
-  if (VersionIsIetfQuic(transport_version)) {
-    return PROTOCOL_TLS1_3;
-  }
-  if (transport_version == QUIC_VERSION_46) {
-    return PROTOCOL_QUIC_CRYPTO;
-  }
-  return PROTOCOL_UNSUPPORTED;
-}
-
 // A parsed QUIC version label which determines that handshake protocol
 // and the transport version.
 struct QUICHE_EXPORT ParsedQuicVersion {
@@ -296,11 +272,6 @@
 QUICHE_EXPORT std::ostream& operator<<(
     std::ostream& os, const QuicVersionLabelVector& version_labels);
 
-// This vector contains all crypto handshake protocols that are supported.
-constexpr std::array<HandshakeProtocol, 2> SupportedHandshakeProtocols() {
-  return {PROTOCOL_TLS1_3, PROTOCOL_QUIC_CRYPTO};
-}
-
 constexpr std::array<ParsedQuicVersion, 4> SupportedVersions() {
   return {
       ParsedQuicVersion::RFCv2(),