commit 73629e33e13fdb42f759e0c32509bbb0beb08843
author QUICHE team <quiche-dev@google.com> Mon Jun 09 12:22:34 2025 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Jun 09 12:24:17 2025 -0700
tree 767589ca78932c0a5216558e232b6c2ca86cd65c
parent d3e1811236b35c531eb716261d90d47a800d6d20

Fix a casting issue in QuicInlinedStringView which causes compilation failures on some platforms with `-Wsign-compare`.

PiperOrigin-RevId: 769246991

quiche/quic/core/quic_inlined_string_view.h

diff --git a/quiche/quic/core/quic_inlined_string_view.h b/quiche/quic/core/quic_inlined_string_view.h
index 4d3ef3f..23d01fc 100644
--- a/quiche/quic/core/quic_inlined_string_view.h
+++ b/quiche/quic/core/quic_inlined_string_view.h
@@ -47,7 +47,7 @@
       return;
     }
 
-    QUICHE_DCHECK_EQ(source.size() & (~kLengthMask), 0);
+    QUICHE_DCHECK_EQ(source.size() & (~kLengthMask), size_t{0});
     if (source.size() > kMaxInlinedSize) {
       ViewRep rep;
       rep.data = source.data();
@@ -97,7 +97,7 @@
   // 32-bit platforms.
   static constexpr size_t kLengthMask =
       sizeof(size_t) > 4 ? ((std::numeric_limits<size_t>::max() << 8) >> 8)
-                         : 0xffffffff;
+                         : std::numeric_limits<size_t>::max();
   static constexpr size_t kNotInlinedMarker = 0xff;
 
 #if defined(__x86_64__)