commit 732ad76d7eff41188e8497f4796c8b4347da7b63
author ericorth <ericorth@google.com> Wed Jul 06 12:09:41 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Jul 06 12:11:54 2022 -0700
tree 337ec73c57e3379db624335c427065c47fee8a24
parent a4a97c70a155b9194ed1c05d0c5254091afa5c52

Fix ASAN error in socket_test.cc

Need to pass an explicit size when building a string_view from a non-null-terminated char array.  Manually confirmed this fix switches the test from fail to pass when running with the relevant ASAN flags.

PiperOrigin-RevId: 459311257

quiche/quic/core/io/socket_test.cc

diff --git a/quiche/quic/core/io/socket_test.cc b/quiche/quic/core/io/socket_test.cc
index f738174..9afe0f6 100644
--- a/quiche/quic/core/io/socket_test.cc
+++ b/quiche/quic/core/io/socket_test.cc
@@ -185,7 +185,8 @@
 
   char buffer[] = {12, 34, 56, 78};
   // Expect at least some data to be sent successfully.
-  absl::StatusOr<absl::string_view> result = socket_api::Send(socket, buffer);
+  absl::StatusOr<absl::string_view> result =
+      socket_api::Send(socket, absl::string_view(buffer, sizeof(buffer)));
   ASSERT_TRUE(result.ok());
   EXPECT_THAT(result.value(), SizeIs(Lt(4)));