commit 62446bcd3c0851334d81fcf91c86ee774bc2398b
author bnc <bnc@google.com> Thu Mar 14 06:11:25 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Mar 14 06:11:53 2019 -0700
tree a54621238f93305c7fb3fcccd2006358cf7a9537
parent 0fb4443404650b7cf4e96230d794666ba96d7793

Add frame header and payload length argument to HttpDecoder::Visitor::OnHeadersFrameStart().

QuicSpdyStream, a HttpDecoder::Visitor implementation, needs to know the HEADERS
frame length in order to call SpdyStreamSequencer::MarkConsumed() when
appropriate.  This CL is chipped off of the draft CL at cr/231494986.

gfe-relnote: n/a.  Change in QUIC v99 only.
PiperOrigin-RevId: 238428175
Change-Id: Icff25fe34f04b96449cfcf4ed62f42e0b2e66c0f

quic/core/http/http_decoder.h

diff --git a/quic/core/http/http_decoder.h b/quic/core/http/http_decoder.h
index 47d97b6..cbfa65e 100644
--- a/quic/core/http/http_decoder.h
+++ b/quic/core/http/http_decoder.h
@@ -17,9 +17,9 @@
 
 class QuicDataReader;
 
-// Struct that stores meta data of a data frame.
-// |header_length| stores number of bytes header occupies.
-// |payload_length| stores number of bytes payload occupies.
+// Struct that stores meta data of an HTTP/3 frame.
+// |header_length| is frame header length in bytes.
+// |payload_length| is frame payload length in bytes.
 struct QUIC_EXPORT_PRIVATE Http3FrameLengths {
   Http3FrameLengths(QuicByteCount header, QuicByteCount payload)
       : header_length(header), payload_length(payload) {}
@@ -62,8 +62,8 @@
     // Called when a DUPLICATE_PUSH frame has been successfully parsed.
     virtual void OnDuplicatePushFrame(const DuplicatePushFrame& frame) = 0;
 
-    // Called when a DATA frame has been received, |frame_lengths| will be
-    // passed to inform header length and payload length of the frame.
+    // Called when a DATA frame has been received.
+    // |frame_length| contains DATA frame length and payload length.
     virtual void OnDataFrameStart(Http3FrameLengths frame_length) = 0;
     // Called when the payload of a DATA frame has read. May be called
     // multiple times for a single frame.
@@ -72,7 +72,8 @@
     virtual void OnDataFrameEnd() = 0;
 
     // Called when a HEADERS frame has been recevied.
-    virtual void OnHeadersFrameStart() = 0;
+    // |frame_length| contains HEADERS frame length and payload length.
+    virtual void OnHeadersFrameStart(Http3FrameLengths frame_length) = 0;
     // Called when the payload of a HEADERS frame has read. May be called
     // multiple times for a single frame.
     virtual void OnHeadersFramePayload(QuicStringPiece payload) = 0;