Migration from GFE_BUG_V2 (and friends) to GFE_BUG
Per go/gfe-bug-improvements GFE_BUGs are getting stable IDs to allow for monitoring and alerting. To achieve that, a temporary set of V2 macros was added and the codebase was migrated to using the V2 macros. Now that migration is complete, the old-style (sans _V2) macros were changed to also take bug_id parameter, which makes the V2 set obsolete. To complete the transition, the codebase is being migrated back to GFE_BUG macros. Once done, V2 macros will be removed.
PiperOrigin-RevId: 363282323
Change-Id: I449be0659402ebded0e12384b1bda9017e528b8f
diff --git a/quic/core/quic_data_writer.cc b/quic/core/quic_data_writer.cc
index 578eea5..ee3c861 100644
--- a/quic/core/quic_data_writer.cc
+++ b/quic/core/quic_data_writer.cc
@@ -201,8 +201,8 @@
const QuicVariableLengthIntegerLength min_length = GetVarInt62Len(value);
if (write_length < min_length) {
- QUIC_BUG_V2(quic_bug_10347_1) << "Cannot write value " << value
- << " with write_length " << write_length;
+ QUIC_BUG(quic_bug_10347_1) << "Cannot write value " << value
+ << " with write_length " << write_length;
return false;
}
if (write_length == min_length) {
@@ -220,7 +220,7 @@
WriteUInt32(value);
}
- QUIC_BUG_V2(quic_bug_10347_2)
+ QUIC_BUG(quic_bug_10347_2)
<< "Invalid write_length " << static_cast<int>(write_length);
return false;
}
@@ -228,8 +228,8 @@
// static
QuicVariableLengthIntegerLength QuicDataWriter::GetVarInt62Len(uint64_t value) {
if ((value & kVarInt62ErrorMask) != 0) {
- QUIC_BUG_V2(quic_bug_10347_3) << "Attempted to encode a value, " << value
- << ", that is too big for VarInt62";
+ QUIC_BUG(quic_bug_10347_3) << "Attempted to encode a value, " << value
+ << ", that is too big for VarInt62";
return VARIABLE_LENGTH_INTEGER_LENGTH_0;
}
if ((value & kVarInt62Mask8Bytes) != 0) {
