Refactor incoming SETTINGS logic to QuicSpdySession::OnSetting().
Move Google QUIC logic from QuicSpdySession::SpdyFramerVisitor::OnSettings(),
and IETF QUIC logic from QuicReceiveControlStream::OnSettingsFrame() together
into new method QuicSpdySession::OnSetting().
Consistently use spdy:: settings identifiers for former and quic:: settings
identifiers for latter. (This reverts part of what I did at cr/260526616. My
confusion about the two different kind of settings is in great part what
motivates this CL so that all SETTINGS logic is in one place).
Inline a number of QuicSpdySession methods now that they are not called from
outside the class:
* UpdateHeaderEncoderTableSize(),
* UpdateEnableServerPush(),
* set_server_push_enabled(),
* set_max_outbound_header_list_size().
This change does not modify behavior. Note that in case of Google QUIC, settings
identifiers (uint16_t) and values (uint32_t) are cast to uint64_t then back to
their respective type, which is a no-op.
gfe-relnote: n/a, no behavioral change.
PiperOrigin-RevId: 260752115
Change-Id: I6b24c98542375e55d907027127ffa1149eaffea6
diff --git a/quic/core/http/quic_spdy_session.h b/quic/core/http/quic_spdy_session.h
index 8d8bbda..1fa0be7 100644
--- a/quic/core/http/quic_spdy_session.h
+++ b/quic/core/http/quic_spdy_session.h
@@ -143,9 +143,8 @@
bool server_push_enabled() const { return server_push_enabled_; }
- // Called by |QuicHeadersStream::UpdateEnableServerPush()| with
- // value from SETTINGS_ENABLE_PUSH.
- void set_server_push_enabled(bool enable) { server_push_enabled_ = enable; }
+ // Called when a setting is parsed from an incoming SETTINGS frame.
+ void OnSetting(uint64_t id, uint64_t value);
// Return true if this session wants to release headers stream's buffer
// aggressively.
@@ -160,10 +159,6 @@
max_inbound_header_list_size_ = max_inbound_header_list_size;
}
- void set_max_outbound_header_list_size(size_t max_outbound_header_list_size) {
- max_outbound_header_list_size_ = max_outbound_header_list_size;
- }
-
size_t max_outbound_header_list_size() const {
return max_outbound_header_list_size_;
}
