Google Git
Sign in
quiche / quiche / 442f894c74b535b1927141b2d0cab84772dee516
commit442f894c74b535b1927141b2d0cab84772dee516[log] [tgz]
authordanzh <danzh@google.com>Wed Nov 11 16:16:34 2020 -0800
committerCopybara-Service <copybara-worker@google.com>Wed Nov 11 16:17:06 2020 -0800
tree17ee79f6d541c6cdf3db501262b721270dcb7052
parent58b3af34cc3580aa680397066cfa22514b8914d4 [diff]
Move const declarations into quic_stream_sequencer_buffer.cc

constexpr members of a class require definition in addition to declaration and initialization.
In Chromium, it is a link error:
error: undefined symbol: quic::QuicStreamSequencerBuffer::kInitialBlockCount
>>> referenced by quic_stream_sequencer_buffer.cc:88 (../../net/third_party/quiche/src/quic/core/quic_stream_sequencer_buffer.cc:88)
>>>               obj/net/third_party/quiche/quiche/quic_stream_sequencer_buffer.o:(quic::QuicStreamSequencerBuffer::MaybeAddMoreBlocks(unsigned long))
clang: error: linker command failed with exit code 1 (use -v to see invocation)

kInitialBlockCount, kBlocksGrowthFactor are only used in .cc file.

PiperOrigin-RevId: 341931802
Change-Id: Ie0dfb5d4f777bdcb68ce9cf7327d589d58dd64ff
2 files changed
tree: 17ee79f6d541c6cdf3db501262b721270dcb7052
  1. common/
  2. epoll_server/
  3. http2/
  4. quic/
  5. spdy/
  6. CONTRIBUTING.md
  7. LICENSE
  8. README.md
README.md

QUICHE

QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects. QUICHE is only supported on little-endian platforms.