commit 4bf78e216967dab9a5722f484df95349c52d70c8
author fayang <fayang@google.com> Mon Aug 03 08:29:48 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 03 08:30:33 2020 -0700
tree 41100a57abad2c53ac1c1e77705e13e0520eb89a
parent 95d85af7aa56429eb52ad33bc67057c9d0e4cb8c

Deprecate gfe2_reloadable_flag_quic_fix_undecryptable_packets.

PiperOrigin-RevId: 324608312
Change-Id: Ibee323f6c6bd5d49a59abe0249745b9a36820dfc

quic/core/quic_connection_test.cc

diff --git a/quic/core/quic_connection_test.cc b/quic/core/quic_connection_test.cc
index 97e5a4a..4d3189d 100644
--- a/quic/core/quic_connection_test.cc
+++ b/quic/core/quic_connection_test.cc
@@ -11215,13 +11215,8 @@
   connection_.SetDefaultEncryptionLevel(ENCRYPTION_HANDSHAKE);
   connection_.SetEncrypter(ENCRYPTION_HANDSHAKE,
                            std::make_unique<TaggingEncrypter>(0x01));
-  if (GetQuicReloadableFlag(quic_fix_undecryptable_packets)) {
-    // Verify all ENCRYPTION_HANDSHAKE packets get processed.
-    EXPECT_CALL(visitor_, OnStreamFrame(_)).Times(6);
-  } else {
-    // Verify packets before 4 get processed.
-    EXPECT_CALL(visitor_, OnStreamFrame(_)).Times(3);
-  }
+  // Verify all ENCRYPTION_HANDSHAKE packets get processed.
+  EXPECT_CALL(visitor_, OnStreamFrame(_)).Times(6);
   connection_.GetProcessUndecryptablePacketsAlarm()->Fire();
   EXPECT_EQ(4u, QuicConnectionPeer::NumUndecryptablePackets(&connection_));
 
@@ -11231,13 +11226,8 @@
   connection_.SetDefaultEncryptionLevel(ENCRYPTION_FORWARD_SECURE);
   connection_.SetEncrypter(ENCRYPTION_FORWARD_SECURE,
                            std::make_unique<TaggingEncrypter>(0x02));
-  if (GetQuicReloadableFlag(quic_fix_undecryptable_packets)) {
-    // Verify the 1-RTT packet gets processed.
-    EXPECT_CALL(visitor_, OnStreamFrame(_)).Times(1);
-  } else {
-    // Verify all packets get processed.
-    EXPECT_CALL(visitor_, OnStreamFrame(_)).Times(4);
-  }
+  // Verify the 1-RTT packet gets processed.
+  EXPECT_CALL(visitor_, OnStreamFrame(_)).Times(1);
   connection_.GetProcessUndecryptablePacketsAlarm()->Fire();
   EXPECT_EQ(0u, QuicConnectionPeer::NumUndecryptablePackets(&connection_));
 }