commit 4b1a5e6bb9c8099ca0beb2eb6b3d7a89650c0c96
author wub <wub@google.com> Thu Jun 06 12:20:05 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Jun 07 08:29:32 2019 -0700
tree e3a421a3b14201a6f50b6eaf0ad6f87b259c3684
parent c5b0e2e8cc620fe3bdae94646d37e5b66d6324bd

gfe-relnote: Remove num_stateless_rejects_received_ from QuicClientBase. Cleanup only, not protected.

PiperOrigin-RevId: 251901425
Change-Id: I2c0f3e2158d8a38d974939ce9ddbf4600ac51bb0

quic/tools/quic_client_base.h

diff --git a/quic/tools/quic_client_base.h b/quic/tools/quic_client_base.h
index 13f7c94..fb15b86 100644
--- a/quic/tools/quic_client_base.h
+++ b/quic/tools/quic_client_base.h
@@ -149,31 +149,17 @@
     initial_max_packet_length_ = initial_max_packet_length;
   }
 
-  int num_stateless_rejects_received() const {
-    return num_stateless_rejects_received_;
-  }
-
-  // The number of client hellos sent, taking stateless rejects into
-  // account.  In the case of a stateless reject, the initial
-  // connection object may be torn down and a new one created.  The
-  // user cannot rely upon the latest connection object to get the
-  // total number of client hellos sent, and should use this function
-  // instead.
+  // The number of client hellos sent.
   int GetNumSentClientHellos();
 
   // Gather the stats for the last session and update the stats for the overall
   // connection.
   void UpdateStats();
 
-  // The number of server config updates received.  We assume no
-  // updates can be sent during a previously, statelessly rejected
-  // connection, so only the latest session is taken into account.
+  // The number of server config updates received.
   int GetNumReceivedServerConfigUpdates();
 
-  // Returns any errors that occurred at the connection-level (as
-  // opposed to the session-level).  When a stateless reject occurs,
-  // the error of the last session may not reflect the overall state
-  // of the connection.
+  // Returns any errors that occurred at the connection-level.
   QuicErrorCode connection_error() const;
   void set_connection_error(QuicErrorCode connection_error) {
     connection_error_ = connection_error;
@@ -236,9 +222,7 @@
   // Extract the number of sent client hellos from the session.
   virtual int GetNumSentClientHellosFromSession() = 0;
 
-  // The number of server config updates received.  We assume no
-  // updates can be sent during a previously, statelessly rejected
-  // connection, so only the latest session is taken into account.
+  // The number of server config updates received.
   virtual int GetNumReceivedServerConfigUpdatesFromSession() = 0;
 
   // If this client supports buffering data, resend it.
@@ -329,11 +313,6 @@
   // zero, the default is used.
   QuicByteCount initial_max_packet_length_;
 
-  // The number of stateless rejects received during the current/latest
-  // connection.
-  // TODO(wub): Remove this.
-  int num_stateless_rejects_received_;
-
   // The number of hellos sent during the current/latest connection.
   int num_sent_client_hellos_;
 
@@ -341,9 +320,8 @@
   // opposed to that associated with the last session object).
   QuicErrorCode connection_error_;
 
-  // True when the client is attempting to connect or re-connect the session (in
-  // the case of a stateless reject).  Set to false  between a call to
-  // Disconnect() and the subsequent call to StartConnect().  When
+  // True when the client is attempting to connect.  Set to false between a call
+  // to Disconnect() and the subsequent call to StartConnect().  When
   // connected_or_attempting_connect_ is false, the session object corresponds
   // to the previous client-level connection.
   bool connected_or_attempting_connect_;