commit 498559895801a16347b42ef790b9080757d768cf
author wub <wub@google.com> Wed May 01 14:16:26 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed May 01 21:20:59 2019 -0700
tree ac29fdf7d08dc756959305339d21ce6a96eea634
parent 711bd180182438c31607c52eacbbf153343d0521

gfe-relnote: (n/a) Change SetQuicFlag to take the flag variable directly instead of a pointer to it. Refactor for Envoy integration, no behavior change.

This is needed for Envoy integration because the current syntax(SetQuicFlag(&FLAG_foo)) requires FLAG_foo is a valid c++ identifier, which is not the case in Envoy.

PiperOrigin-RevId: 246196929
Change-Id: I7d56b23f0fa51fcdd17acc0837508710316a6826

quic/core/quic_stream_test.cc

diff --git a/quic/core/quic_stream_test.cc b/quic/core/quic_stream_test.cc
index b9d97a1..bfe88f7 100644
--- a/quic/core/quic_stream_test.cc
+++ b/quic/core/quic_stream_test.cc
@@ -956,7 +956,7 @@
 }
 
 TEST_P(QuicStreamTest, CanWriteNewDataAfterData) {
-  SetQuicFlag(&FLAGS_quic_buffered_data_threshold, 100);
+  SetQuicFlag(FLAGS_quic_buffered_data_threshold, 100);
   Initialize();
   EXPECT_TRUE(stream_->CanWriteNewDataAfterData(99));
   EXPECT_FALSE(stream_->CanWriteNewDataAfterData(100));
@@ -964,7 +964,7 @@
 
 TEST_P(QuicStreamTest, WriteBufferedData) {
   // Set buffered data low water mark to be 100.
-  SetQuicFlag(&FLAGS_quic_buffered_data_threshold, 100);
+  SetQuicFlag(FLAGS_quic_buffered_data_threshold, 100);
   // Do not stream level flow control block this stream.
   set_initial_flow_control_window_bytes(500000);
 
@@ -1098,7 +1098,7 @@
 
 TEST_P(QuicStreamTest, WriteMemSlices) {
   // Set buffered data low water mark to be 100.
-  SetQuicFlag(&FLAGS_quic_buffered_data_threshold, 100);
+  SetQuicFlag(FLAGS_quic_buffered_data_threshold, 100);
   // Do not flow control block this stream.
   set_initial_flow_control_window_bytes(500000);