gfe-relnote: (n/a) Change SetQuicFlag to take the flag variable directly instead of a pointer to it. Refactor for Envoy integration, no behavior change.
This is needed for Envoy integration because the current syntax(SetQuicFlag(&FLAG_foo)) requires FLAG_foo is a valid c++ identifier, which is not the case in Envoy.
PiperOrigin-RevId: 246196929
Change-Id: I7d56b23f0fa51fcdd17acc0837508710316a6826
diff --git a/quic/core/quic_dispatcher_test.cc b/quic/core/quic_dispatcher_test.cc
index f280717..89befc5 100644
--- a/quic/core/quic_dispatcher_test.cc
+++ b/quic/core/quic_dispatcher_test.cc
@@ -195,7 +195,7 @@
: QuicDispatcherTest(crypto_test_utils::ProofSourceForTesting()) {}
ParsedQuicVersionVector AllSupportedVersionsIncludingTls() {
- SetQuicFlag(&FLAGS_quic_supports_tls_handshake, true);
+ SetQuicFlag(FLAGS_quic_supports_tls_handshake, true);
return AllSupportedVersions();
}
@@ -380,7 +380,7 @@
// TLS is only supported in versions 47 and greater.
return;
}
- SetQuicFlag(&FLAGS_quic_supports_tls_handshake, true);
+ SetQuicFlag(FLAGS_quic_supports_tls_handshake, true);
QuicSocketAddress client_address(QuicIpAddress::Loopback4(), 1);
EXPECT_CALL(*dispatcher_,
