commit 439c769337517b9a741267738e71fcdb0c06139a
author renjietang <renjietang@google.com> Wed Jan 22 18:36:28 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Jan 22 18:37:06 2020 -0800
tree 7df8c60502fa3d3436d698c089412cb225f64b77
parent 6932faffa7a58e86525b7bff6085de0c15e3ad73

gfe-relnote: Fix a missing code count for spdy DECOMPRESS_FAILURE.

PiperOrigin-RevId: 291076935
Change-Id: I4b0b464fd88f4a5e0957a14335a3c163476167a2

spdy/core/hpack/hpack_decoder_adapter.cc

diff --git a/spdy/core/hpack/hpack_decoder_adapter.cc b/spdy/core/hpack/hpack_decoder_adapter.cc
index d93fa22..fe9577d 100644
--- a/spdy/core/hpack/hpack_decoder_adapter.cc
+++ b/spdy/core/hpack/hpack_decoder_adapter.cc
@@ -49,7 +49,7 @@
     header_block_started_ = true;
     if (!hpack_decoder_.StartDecodingBlock()) {
       header_block_started_ = false;
-      SPDY_CODE_COUNT_N(decompress_failure, 1, 4);
+      SPDY_CODE_COUNT_N(decompress_failure_2, 1, 5);
       return false;
     }
   }
@@ -63,18 +63,21 @@
       SPDY_DVLOG(1) << "max_decode_buffer_size_bytes_ < headers_data_length: "
                     << max_decode_buffer_size_bytes_ << " < "
                     << headers_data_length;
-      SPDY_CODE_COUNT_N(decompress_failure, 2, 4);
+      SPDY_CODE_COUNT_N(decompress_failure_2, 2, 5);
       return false;
     }
     listener_adapter_.AddToTotalHpackBytes(headers_data_length);
     if (max_header_block_bytes_ != 0 &&
         listener_adapter_.total_hpack_bytes() > max_header_block_bytes_) {
-      SPDY_CODE_COUNT_N(decompress_failure, 3, 4);
+      SPDY_CODE_COUNT_N(decompress_failure, 3, 5);
       return false;
     }
     http2::DecodeBuffer db(headers_data, headers_data_length);
     bool ok = hpack_decoder_.DecodeFragment(&db);
     DCHECK(!ok || db.Empty()) << "Remaining=" << db.Remaining();
+    if (!ok) {
+      SPDY_CODE_COUNT_N(decompress_failure_2, 4, 5);
+    }
     return ok;
   }
   return true;
@@ -88,7 +91,7 @@
   }
   if (!hpack_decoder_.EndDecodingBlock()) {
     SPDY_DVLOG(3) << "EndDecodingBlock returned false";
-    SPDY_CODE_COUNT_N(decompress_failure, 4, 4);
+    SPDY_CODE_COUNT_N(decompress_failure_2, 5, 5);
     return false;
   }
   header_block_started_ = false;