commit 40038f52168279670e1e2fe7865e1dd4c30fceca
author renjietang <renjietang@google.com> Wed Apr 08 11:30:31 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Apr 08 11:31:26 2020 -0700
tree 1a936e6049e34a57952d8bb50f77d3d40e0cbd4f
parent 18aef545a83c01790869257820fb11e3d5efefa2

Remove QuicStreamIdManager::IsIncomingStream() as it's hard coded. Also QuicSession doesn't need the indirectness.

QuicUtils should be the single source of truth.

gfe-relnote: no behavior change. not protected.
PiperOrigin-RevId: 305518573
Change-Id: I926c93ccd33f12c694b823d764a88d13df3e6c94

quic/core/quic_stream_id_manager.h

diff --git a/quic/core/quic_stream_id_manager.h b/quic/core/quic_stream_id_manager.h
index cf1e81e..bdcb7cb 100644
--- a/quic/core/quic_stream_id_manager.h
+++ b/quic/core/quic_stream_id_manager.h
@@ -32,7 +32,7 @@
   QuicStreamIdManager(DelegateInterface* delegate,
                       bool unidirectional,
                       Perspective perspective,
-                      QuicTransportVersion transport_version,
+                      ParsedQuicVersion version,
                       QuicStreamCount max_allowed_outgoing_streams,
                       QuicStreamCount max_allowed_incoming_streams);
 
@@ -92,9 +92,6 @@
   // Returns true if |id| is still available.
   bool IsAvailableStream(QuicStreamId id) const;
 
-  // Return true if given stream is peer initiated.
-  bool IsIncomingStream(QuicStreamId id) const;
-
   QuicStreamCount incoming_initial_max_open_streams() const {
     return incoming_initial_max_open_streams_;
   }
@@ -104,7 +101,7 @@
   }
 
   // Number of streams that the peer believes that it can still create.
-  QuicStreamCount available_incoming_streams();
+  QuicStreamCount available_incoming_streams() const;
 
   QuicStreamId largest_peer_created_stream_id() const {
     return largest_peer_created_stream_id_;
@@ -117,7 +114,9 @@
   QuicStreamCount incoming_advertised_max_streams() const {
     return incoming_advertised_max_streams_;
   }
-  QuicStreamCount outgoing_stream_count() { return outgoing_stream_count_; }
+  QuicStreamCount outgoing_stream_count() const {
+    return outgoing_stream_count_;
+  }
 
  private:
   friend class test::QuicSessionPeer;
@@ -143,8 +142,8 @@
   // Is this manager a client or a server.
   const Perspective perspective_;
 
-  // Transport version used for this manager.
-  const QuicTransportVersion transport_version_;
+  // QUIC version used for this manager.
+  const ParsedQuicVersion version_;
 
   // The number of streams that this node can initiate.
   // This limit is first set when config is negotiated, but may be updated upon