Google Git
Sign in
quiche / quiche / 3ee025f71c841545f95e6d5dbd43fd72d9b5371d
commit3ee025f71c841545f95e6d5dbd43fd72d9b5371d[log] [tgz]
authorwub <wub@google.com>Tue Nov 26 11:19:27 2019 -0800
committerCopybara-Service <copybara-worker@google.com>Tue Nov 26 11:20:04 2019 -0800
treefb9c03e961c911bf68644045a2a5b98a4a5da061
parent61cc245fc381b5f826936122554adff0af8c4107 [diff]
gfe-relnote: (n/a) In QuicTimeAccumulator, change a "static constexpr data member" to a "static constexpr function". No behavior change, not protected.

This caused a merge error in Chromium because QuicTimeAccumulator::kNotRunningSentinel does not have a definition. The requirement for a definition has been removed since c++17.

I could not think of a clean way to prevent this in presubmit, simply ban "static constexpr QuicTime" seems too restrictive, because some code may want to use it with a definition in .cc.

PiperOrigin-RevId: 282603664
Change-Id: Ia677ca93b851725e4509c4960c5e71fdeac5f903
1 file changed
tree: fb9c03e961c911bf68644045a2a5b98a4a5da061
  1. common/
  2. epoll_server/
  3. http2/
  4. quic/
  5. spdy/
  6. CONTRIBUTING.md
  7. LICENSE
  8. README.md
README.md

QUICHE

QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects.