commit 3ecc53bf310c6f7d0b1f2240290ed14f716d6341
author fayang <fayang@google.com> Thu Mar 12 07:12:03 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Mar 12 07:12:45 2020 -0700
tree 25dbaa25dbe3756fb6c6d0172c0434b3a4ffdac4
parent 731f4478d716c67830e2a14c629f0beb433c9eb4

gfe-relnote: Initialize packet_number_space to invalid value in GetRetransmissionTime. No functional change expected, not protected.

This is used to fix msan failures where tests do not mark handshake complete or packets do not go through sent packet manager (e.g., handshaker unittests).

PiperOrigin-RevId: 300542046
Change-Id: Ia7fae43fec73fa5e2521f84961b352e002a3e28a

quic/core/quic_sent_packet_manager.cc

diff --git a/quic/core/quic_sent_packet_manager.cc b/quic/core/quic_sent_packet_manager.cc
index 09f92e1..1b62e67 100644
--- a/quic/core/quic_sent_packet_manager.cc
+++ b/quic/core/quic_sent_packet_manager.cc
@@ -1068,7 +1068,7 @@
                             GetProbeTimeoutDelay());
       }
 
-      PacketNumberSpace packet_number_space;
+      PacketNumberSpace packet_number_space = NUM_PACKET_NUMBER_SPACES;
       // earliest_right_edge is the earliest sent time of the last in flight
       // packet of all packet number spaces.
       const QuicTime earliest_right_edge =