Add QuicStreamsBlockedFrame and QuicMaxStreamsFrame classes
There are two main parts to this work
1) connecting up the new frames, replacing the old ones, to move data around the
system. This also entails a lot of editorial changes (just changing names, comments,
and so on, without notable logic chanages -- eg, "OnMaxStreamIdFrame" becomes
"OnMaxStreamsFrame".
2) the second, and more complex, task is revising the stream id manager to work entirely
with stream counts rather than stream-ids. For example, the logic to check whether a
new stream can be created checks if the current-stream-count is less than the limit
or not, rather than if the next stream id to hand out is above the limit or not.
For all intents and purposes, this completely rewrote the stream ID manager.
Another big change resulting from keeping track solely of stream counts is that the
stream ID manager doesn't care whether it is doing unidirectional or bidirectional
streams, nor does it care whether stream ids are client- or server- initiated.
gfe-relnote: N/A, all changes are for V99/IETF QUIC code only.
LOG_STORAGE_INCREASE(GB/week): 0
TMPLOG_STORAGE_INCREASE(GB): 0
This change neither adds nor deletes data stored. It adds two new codepoints to the QUIC FrameType enum. These new enums reflect two new frames defined in IETF QUIC, which replace two now-deprecated frames (and their associated type codepoints). This is a name change/type codepoint extension; data is neither added nor deleted.
PiperOrigin-RevId: 244661277
Change-Id: I07cdb79db6bd15e1d5ece97b3aa2d67e94ccf00b
diff --git a/quic/core/quic_framer.h b/quic/core/quic_framer.h
index 90ef998..b20ac92 100644
--- a/quic/core/quic_framer.h
+++ b/quic/core/quic_framer.h
@@ -201,12 +201,11 @@
virtual void OnAuthenticatedIetfStatelessResetPacket(
const QuicIetfStatelessResetPacket& packet) = 0;
- // Called when an IETF MaxStreamId frame has been parsed.
- virtual bool OnMaxStreamIdFrame(const QuicMaxStreamIdFrame& frame) = 0;
+ // Called when an IETF MaxStreams frame has been parsed.
+ virtual bool OnMaxStreamsFrame(const QuicMaxStreamsFrame& frame) = 0;
- // Called when an IETF StreamIdBlocked frame has been parsed.
- virtual bool OnStreamIdBlockedFrame(
- const QuicStreamIdBlockedFrame& frame) = 0;
+ // Called when an IETF StreamsBlocked frame has been parsed.
+ virtual bool OnStreamsBlockedFrame(const QuicStreamsBlockedFrame& frame) = 0;
};
// Class for parsing and constructing QUIC packets. It has a
@@ -309,11 +308,11 @@
const QuicWindowUpdateFrame& frame);
// Size in bytes of all MaxStreams frame fields.
static size_t GetMaxStreamsFrameSize(QuicTransportVersion version,
- const QuicMaxStreamIdFrame& frame);
+ const QuicMaxStreamsFrame& frame);
// Size in bytes of all StreamsBlocked frame fields.
static size_t GetStreamsBlockedFrameSize(
QuicTransportVersion version,
- const QuicStreamIdBlockedFrame& frame);
+ const QuicStreamsBlockedFrame& frame);
// Size in bytes of all Blocked frame fields.
static size_t GetBlockedFrameSize(QuicTransportVersion version,
const QuicBlockedFrame& frame);
@@ -809,10 +808,10 @@
bool ProcessMaxStreamDataFrame(QuicDataReader* reader,
QuicWindowUpdateFrame* frame);
- bool AppendMaxStreamsFrame(const QuicMaxStreamIdFrame& frame,
+ bool AppendMaxStreamsFrame(const QuicMaxStreamsFrame& frame,
QuicDataWriter* writer);
bool ProcessMaxStreamsFrame(QuicDataReader* reader,
- QuicMaxStreamIdFrame* frame,
+ QuicMaxStreamsFrame* frame,
uint64_t frame_type);
bool AppendIetfBlockedFrame(const QuicBlockedFrame& frame,
@@ -824,10 +823,10 @@
bool ProcessStreamBlockedFrame(QuicDataReader* reader,
QuicBlockedFrame* frame);
- bool AppendStreamsBlockedFrame(const QuicStreamIdBlockedFrame& frame,
+ bool AppendStreamsBlockedFrame(const QuicStreamsBlockedFrame& frame,
QuicDataWriter* writer);
bool ProcessStreamsBlockedFrame(QuicDataReader* reader,
- QuicStreamIdBlockedFrame* frame,
+ QuicStreamsBlockedFrame* frame,
uint64_t frame_type);
bool AppendNewConnectionIdFrame(const QuicNewConnectionIdFrame& frame,
