commit 2c546d597476c912b1c71222a64fb03feb274381
author rch <rch@google.com> Mon Dec 08 14:55:30 2025 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Dec 08 14:56:20 2025 -0800
tree edead1b1a9baacf8bab72f5d2096bdaefc54cafd
parent 4f0537d14eddab2a594d0f57771cdd16c2ae5788

Remove redundant method ParsedQuicVersionIsValid.

PiperOrigin-RevId: 841926878

quiche/quic/core/quic_versions.h

diff --git a/quiche/quic/core/quic_versions.h b/quiche/quic/core/quic_versions.h
index 20f7905..b2bce99 100644
--- a/quiche/quic/core/quic_versions.h
+++ b/quiche/quic/core/quic_versions.h
@@ -184,15 +184,6 @@
   return false;
 }
 
-// Returns whether this combination of handshake protocol and transport
-// version is allowed. For example, {PROTOCOL_TLS1_3, QUIC_VERSION_46} is NOT
-// allowed as TLS requires crypto frames which v46 does not support. Note that
-// UnsupportedQuicVersion is a valid version.
-QUICHE_EXPORT constexpr bool ParsedQuicVersionIsValid(
-    QuicTransportVersion transport_version) {
-  return TransportVersionIsValid(transport_version);
-}
-
 QUICHE_EXPORT constexpr HandshakeProtocol HandshakeProtocolForTransportVersion(
     QuicTransportVersion transport_version) {
   if (VersionIsIetfQuic(transport_version)) {
@@ -250,7 +241,7 @@
   }
 
   // Returns whether our codebase understands this version. This should only be
-  // called on valid versions, see ParsedQuicVersionIsValid. Assuming the
+  // called on valid versions, see TransportVersionIsValid. Assuming the
   // version is valid, IsKnown returns whether the version is not
   // UnsupportedQuicVersion.
   bool IsKnown() const;

quiche/quic/core/quic_versions_test.cc

diff --git a/quiche/quic/core/quic_versions_test.cc b/quiche/quic/core/quic_versions_test.cc
index ac6c847..0d4af51 100644
--- a/quiche/quic/core/quic_versions_test.cc
+++ b/quiche/quic/core/quic_versions_test.cc
@@ -32,18 +32,18 @@
 TEST(QuicVersionsTest, KnownAndValid) {
   for (const ParsedQuicVersion& version : AllSupportedVersions()) {
     EXPECT_TRUE(version.IsKnown());
-    EXPECT_TRUE(ParsedQuicVersionIsValid(version.transport_version));
+    EXPECT_TRUE(TransportVersionIsValid(version.transport_version));
   }
   ParsedQuicVersion unsupported = UnsupportedQuicVersion();
   EXPECT_FALSE(unsupported.IsKnown());
-  EXPECT_TRUE(ParsedQuicVersionIsValid(unsupported.transport_version));
+  EXPECT_TRUE(TransportVersionIsValid(unsupported.transport_version));
   ParsedQuicVersion reserved = QuicVersionReservedForNegotiation();
   EXPECT_TRUE(reserved.IsKnown());
-  EXPECT_TRUE(ParsedQuicVersionIsValid(reserved.transport_version));
+  EXPECT_TRUE(TransportVersionIsValid(reserved.transport_version));
   // Check that deprecated versions are not valid.
-  EXPECT_FALSE(ParsedQuicVersionIsValid(static_cast<QuicTransportVersion>(33)));
-  EXPECT_FALSE(ParsedQuicVersionIsValid(static_cast<QuicTransportVersion>(43)));
-  EXPECT_FALSE(ParsedQuicVersionIsValid(static_cast<QuicTransportVersion>(99)));
+  EXPECT_FALSE(TransportVersionIsValid(static_cast<QuicTransportVersion>(33)));
+  EXPECT_FALSE(TransportVersionIsValid(static_cast<QuicTransportVersion>(43)));
+  EXPECT_FALSE(TransportVersionIsValid(static_cast<QuicTransportVersion>(99)));
 }
 
 TEST(QuicVersionsTest, Features) {
@@ -413,7 +413,7 @@
     QuicTransportVersion transport_version =
         static_cast<QuicTransportVersion>(trans_vers);
     SCOPED_TRACE(index);
-    if (ParsedQuicVersionIsValid(transport_version)) {
+    if (TransportVersionIsValid(transport_version)) {
       ParsedQuicVersion version = SupportedVersions()[index];
       EXPECT_EQ(version, ParsedQuicVersion(transport_version));
       index++;