commit 269807ae3d0ac1794fb5ffbb3ecd3d3d230a2633
author davidben <davidben@google.com> Wed Nov 20 14:19:57 2024 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Nov 20 14:21:04 2024 -0800
tree eb58e8193c0ab2f137ccd75081529b124fb7bdfd
parent 7e427ee26c83f243ca49c2c5fabbc6b004a4d21c

Avoid tripping -Wchanges-meaning in GCC

I got this warning building QUICHE with GCC because I forgot to `CC=clang`:

```
quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc:28:19: error: declaration of 'quic::HuffmanEncoding quic::test::{anonymous}::QpackEncoderStreamSenderTest::HuffmanEncoding()' changes meaning of 'HuffmanEncoding' [-Wchanges-meaning]
   28 |   HuffmanEncoding HuffmanEncoding() {
      |                   ^~~~~~~~~~~~~~~
quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc:28:3: note: used here to mean 'enum class quic::HuffmanEncoding'
   28 |   HuffmanEncoding HuffmanEncoding() {
      |   ^~~~~~~~~~~~~~~
```

The fix is easy enough.

PiperOrigin-RevId: 698519906

quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc

diff --git a/quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc b/quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc
index 823cae8..3ebc8f6 100644
--- a/quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc
+++ b/quiche/quic/core/qpack/qpack_encoder_stream_sender_test.cc
@@ -19,13 +19,13 @@
 
 class QpackEncoderStreamSenderTest : public QuicTestWithParam<bool> {
  protected:
-  QpackEncoderStreamSenderTest() : stream_(HuffmanEncoding()) {
+  QpackEncoderStreamSenderTest() : stream_(GetHuffmanEncoding()) {
     stream_.set_qpack_stream_sender_delegate(&delegate_);
   }
   ~QpackEncoderStreamSenderTest() override = default;
 
   bool DisableHuffmanEncoding() { return GetParam(); }
-  HuffmanEncoding HuffmanEncoding() {
+  HuffmanEncoding GetHuffmanEncoding() {
     return DisableHuffmanEncoding() ? HuffmanEncoding::kDisabled
                                     : HuffmanEncoding::kEnabled;
   }