commit 260f2e4e5763e56d0b824119af655cfddc655f78
author bnc <bnc@google.com> Tue Apr 28 10:29:08 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 28 10:29:45 2020 -0700
tree 52f7e0aebf53169273a844752cd54cf3c13e2dd5
parent e3dcdae7520f4b93276ac1e91f37128a0d2475d9

gfe-relnote: Deprecate gfe2_reloadable_flag_spdy_enable_granular_decompress_errors.

PiperOrigin-RevId: 308849205
Change-Id: I14a21b00b8d8b8a3ca7f45e7f831aa23444b5abb

quic/core/http/end_to_end_test.cc

diff --git a/quic/core/http/end_to_end_test.cc b/quic/core/http/end_to_end_test.cc
index 5513a7f..1baa8b8 100644
--- a/quic/core/http/end_to_end_test.cc
+++ b/quic/core/http/end_to_end_test.cc
@@ -3506,11 +3506,8 @@
   client_->SendMessage(headers, "");
   client_->WaitForResponse();
 
-  QuicErrorCode expected_error =
-      GetQuicReloadableFlag(spdy_enable_granular_decompress_errors)
-          ? QUIC_HPACK_INDEX_VARINT_ERROR
-          : QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE;
-  EXPECT_THAT(client_->connection_error(), IsError(expected_error));
+  EXPECT_THAT(client_->connection_error(),
+              IsError(QUIC_HPACK_INDEX_VARINT_ERROR));
 }
 
 class WindowUpdateObserver : public QuicConnectionDebugVisitor {

quic/core/http/quic_spdy_session_test.cc

diff --git a/quic/core/http/quic_spdy_session_test.cc b/quic/core/http/quic_spdy_session_test.cc
index dceccd9..4049caf 100644
--- a/quic/core/http/quic_spdy_session_test.cc
+++ b/quic/core/http/quic_spdy_session_test.cc
@@ -2927,9 +2927,6 @@
     return;
   }
 
-  QuicFlagSaver flag_saver;
-  SetQuicReloadableFlag(spdy_enable_granular_decompress_errors, true);
-
   QuicStreamId request_stream_id = 5;
   session_.CreateIncomingStream(request_stream_id);
 

spdy/core/http2_frame_decoder_adapter.cc

diff --git a/spdy/core/http2_frame_decoder_adapter.cc b/spdy/core/http2_frame_decoder_adapter.cc
index df60047..f23b583 100644
--- a/spdy/core/http2_frame_decoder_adapter.cc
+++ b/spdy/core/http2_frame_decoder_adapter.cc
@@ -92,12 +92,6 @@
 
 Http2DecoderAdapter::SpdyFramerError HpackDecodingErrorToSpdyFramerError(
     HpackDecodingError error) {
-  if (!GetSpdyReloadableFlag(spdy_enable_granular_decompress_errors)) {
-    return Http2DecoderAdapter::SpdyFramerError::SPDY_DECOMPRESS_FAILURE;
-  }
-
-  SPDY_CODE_COUNT(spdy_enable_granular_decompress_errors);
-
   switch (error) {
     case HpackDecodingError::kOk:
       return Http2DecoderAdapter::SpdyFramerError::SPDY_NO_ERROR;