| commit | 22e2812a144a3880e02cab68129fd3c1b58f2001 | [log] [tgz] |
|---|---|---|
| author | bnc <bnc@google.com> | Tue Aug 10 08:32:38 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Aug 10 08:33:08 2021 -0700 |
| tree | cda7c2943acb6544dc092b79f9e3ccdbcf21806a | |
| parent | 095aafa4c48626c14d298e10fd7b7c8b57a9b6f6 [diff] |
Fix more signed-unsigned comparisons in QUICHE. This is in preparation for landing some macro magic that would actually enforce it in test comparison macros. In some places I fixed the issue by adding 'u' to an integer literal. In other places I chose the path of least resistance and modified the build rule. This is okay for files that are not included in Chromium and for which there are no immediate plans to include them. In the long term we might change the Chromium build rules for QUICHE in which case this all becomes moot. Or if we don't, it is obvious that there are violations in the given file, and they can be fixed and the build rule change reverted before including them in the Chromium build. The important part is to make sure currently included files cannot be modified in a -Wsign-compare violating way, so as not to block QUICHE merge. PiperOrigin-RevId: 389891302
QUICHE stands for QUIC, Http/2, Etc. It is Google‘s production-ready implementation of QUIC, HTTP/2, HTTP/3, and related protocols and tools. It powers Google’s servers, Chromium, Envoy, and other projects. It is actively developed and maintained.
There are two public QUICHE repositories. Either one may be used by embedders, as they are automatically kept in sync:
To embed QUICHE in your project, platform APIs need to be implemented and build files need to be created. Note that it is on the QUICHE team's roadmap to include default implementation for all platform APIs and to open-source build files. In the meanwhile, take a look at open source embedders like Chromium and Envoy to get started:
QUICHE is only supported on little-endian platforms.