commit 1f3de24d892f717c37424bcb4ce6bd4c88eb53cd
author QUICHE team <quiche-dev@google.com> Wed Mar 20 07:24:48 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Mar 20 07:25:21 2019 -0700
tree 35bb1e85f9a6a9d65788bb442f9710ec76549e12
parent c65d1d143ba830d14393a29a8234a678e8c68a17

gfe-relnote: In QUIC, add getter for largest received packet to QuicConnection. No functional change expected, not protected.

Also remove getter of received_packet_manager.

PiperOrigin-RevId: 239392053
Change-Id: I3a244583e64df565f7aac57644b5075eb6670821

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index dcea61d..574dd0c 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -887,10 +887,12 @@
   current_effective_peer_migration_type_ = NO_CHANGE;
 
   if (perspective_ == Perspective::IS_CLIENT) {
-    if (!received_packet_manager_.GetLargestObserved().IsInitialized() ||
-        header.packet_number > received_packet_manager_.GetLargestObserved()) {
+    if (!GetLargestReceivedPacket().IsInitialized() ||
+        header.packet_number > GetLargestReceivedPacket()) {
       // Update peer_address_ and effective_peer_address_ immediately for
       // client connections.
+      // TODO(fayang): only change peer addresses in application data packet
+      // number space.
       direct_peer_address_ = last_packet_source_address_;
       effective_peer_address_ = GetEffectivePeerAddressFromCurrentPacket();
     }
@@ -1432,10 +1434,11 @@
                                  /* is_response= */ true);
     }
 
-    if (last_header_.packet_number ==
-        received_packet_manager_.GetLargestObserved()) {
+    if (last_header_.packet_number == GetLargestReceivedPacket()) {
       direct_peer_address_ = last_packet_source_address_;
       if (current_effective_peer_migration_type_ != NO_CHANGE) {
+        // TODO(fayang): When multiple packet number spaces is supported, only
+        // start peer migration for the application data.
         StartEffectivePeerMigration(current_effective_peer_migration_type_);
       }
     }
@@ -3645,13 +3648,14 @@
   }
 
   current_packet_content_ = NOT_PADDED_PING;
-  if (received_packet_manager_.GetLargestObserved().IsInitialized() &&
-      last_header_.packet_number ==
-          received_packet_manager_.GetLargestObserved()) {
+  if (GetLargestReceivedPacket().IsInitialized() &&
+      last_header_.packet_number == GetLargestReceivedPacket()) {
     direct_peer_address_ = last_packet_source_address_;
     if (current_effective_peer_migration_type_ != NO_CHANGE) {
       // Start effective peer migration immediately when the current packet is
       // confirmed not a connectivity probing packet.
+      // TODO(fayang): When multiple packet number spaces is supported, only
+      // start peer migration for the application data.
       StartEffectivePeerMigration(current_effective_peer_migration_type_);
     }
   }
@@ -3822,6 +3826,10 @@
   return sent_packet_manager_.GetLargestObserved();
 }
 
+QuicPacketNumber QuicConnection::GetLargestReceivedPacket() const {
+  return received_packet_manager_.GetLargestObserved();
+}
+
 size_t QuicConnection::min_received_before_ack_decimation() const {
   if (received_packet_manager_.decide_when_to_send_acks()) {
     return received_packet_manager_.min_received_before_ack_decimation();