Fix TlsChloExtractor move assignment operator
The default move assignement operator does not
update the delegates on various members, which
means that callbacks will be sent to the wrong
instance. This CL fixes that and adds a
regression test.
gfe-relnote: n/a, unused code
PiperOrigin-RevId: 308172454
Change-Id: Ie2784af64071b21995207b9ce2341443b4181d26
diff --git a/quic/core/tls_chlo_extractor_test.cc b/quic/core/tls_chlo_extractor_test.cc
index ab99a72..ba57ad0 100644
--- a/quic/core/tls_chlo_extractor_test.cc
+++ b/quic/core/tls_chlo_extractor_test.cc
@@ -104,6 +104,54 @@
TlsChloExtractor::State::kParsedFullMultiPacketChlo);
}
+TEST_P(TlsChloExtractorTest, MoveAssignment) {
+ Initialize();
+ EXPECT_EQ(packets_.size(), 1u);
+ TlsChloExtractor other_extractor;
+ tls_chlo_extractor_ = std::move(other_extractor);
+ IngestPackets();
+ ValidateChloDetails();
+ EXPECT_EQ(tls_chlo_extractor_.state(),
+ TlsChloExtractor::State::kParsedFullSinglePacketChlo);
+}
+
+TEST_P(TlsChloExtractorTest, MoveAssignmentBetweenPackets) {
+ IncreaseSizeOfChlo();
+ Initialize();
+ ASSERT_EQ(packets_.size(), 2u);
+ TlsChloExtractor other_extractor;
+
+ // Have |other_extractor| parse the first packet.
+ ReceivedPacketInfo packet_info(
+ QuicSocketAddress(TestPeerIPAddress(), kTestPort),
+ QuicSocketAddress(TestPeerIPAddress(), kTestPort), *packets_[0]);
+ std::string detailed_error;
+ bool retry_token_present;
+ quiche::QuicheStringPiece retry_token;
+ const QuicErrorCode error = QuicFramer::ParsePublicHeaderDispatcher(
+ *packets_[0], /*expected_destination_connection_id_length=*/0,
+ &packet_info.form, &packet_info.long_packet_type,
+ &packet_info.version_flag, &packet_info.use_length_prefix,
+ &packet_info.version_label, &packet_info.version,
+ &packet_info.destination_connection_id, &packet_info.source_connection_id,
+ &retry_token_present, &retry_token, &detailed_error);
+ ASSERT_THAT(error, IsQuicNoError()) << detailed_error;
+ other_extractor.IngestPacket(packet_info.version, packet_info.packet);
+ // Remove the first packet from the list.
+ packets_.erase(packets_.begin());
+ EXPECT_EQ(packets_.size(), 1u);
+
+ // Move the extractor.
+ tls_chlo_extractor_ = std::move(other_extractor);
+
+ // Have |tls_chlo_extractor_| parse the second packet.
+ IngestPackets();
+
+ ValidateChloDetails();
+ EXPECT_EQ(tls_chlo_extractor_.state(),
+ TlsChloExtractor::State::kParsedFullMultiPacketChlo);
+}
+
} // namespace
} // namespace test
} // namespace quic
