commit 118934b8a030caf24704b5f8efac59ef7c927186
author dschinazi <dschinazi@google.com> Thu Jun 13 18:09:08 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Jun 14 09:41:17 2019 -0700
tree 7c95bdb834a5c6783d0ad3662ef250de5790318f
parent 6ebe83b7608c717c4568d8cdf775f51a05d69c77

Add DV2 logs to help interop debugging

gfe-relnote: adds QUIC_DVLOG(2) logs that are not enabled in production, not flag-protected
PiperOrigin-RevId: 253144347
Change-Id: Ia632d5622aee919b9aa2a84b5bf729c8bde916d1

quic/core/quic_packet_creator.cc

diff --git a/quic/core/quic_packet_creator.cc b/quic/core/quic_packet_creator.cc
index cc59cc7..7ba82e3 100644
--- a/quic/core/quic_packet_creator.cc
+++ b/quic/core/quic_packet_creator.cc
@@ -464,6 +464,8 @@
   }
   QUIC_DVLOG(1) << ENDPOINT << "Adding frame: " << frame;
 
+  QUIC_DVLOG(2) << ENDPOINT << "Serializing stream packet " << header << frame;
+
   // TODO(ianswett): AppendTypeByte and AppendStreamFrame could be optimized
   // into one method that takes a QuicStreamFrame, if warranted.
   bool omit_frame_length = !needs_padding;
@@ -592,6 +594,9 @@
 
   MaybeAddPadding();
 
+  QUIC_DVLOG(2) << ENDPOINT << "Serializing packet " << header
+                << QuicFramesToString(queued_frames_);
+
   DCHECK_GE(max_plaintext_size_, packet_size_);
   // Use the packet_size_ instead of the buffer size to ensure smaller
   // packet sizes are properly used.
@@ -652,6 +657,9 @@
   // FillPacketHeader increments packet_number_.
   FillPacketHeader(&header);
 
+  QUIC_DVLOG(2) << ENDPOINT << "Serializing connectivity probing packet "
+                << header;
+
   std::unique_ptr<char[]> buffer(new char[kMaxOutgoingPacketSize]);
   size_t length = framer_->BuildConnectivityProbingPacket(
       header, buffer.get(), max_plaintext_size_, packet_.encryption_level);
@@ -684,6 +692,8 @@
   // FillPacketHeader increments packet_number_.
   FillPacketHeader(&header);
 
+  QUIC_DVLOG(2) << ENDPOINT << "Serializing path challenge packet " << header;
+
   std::unique_ptr<char[]> buffer(new char[kMaxOutgoingPacketSize]);
   size_t length = framer_->BuildPaddedPathChallengePacket(
       header, buffer.get(), max_plaintext_size_, payload, random_,
@@ -718,6 +728,8 @@
   // FillPacketHeader increments packet_number_.
   FillPacketHeader(&header);
 
+  QUIC_DVLOG(2) << ENDPOINT << "Serializing path response packet " << header;
+
   std::unique_ptr<char[]> buffer(new char[kMaxOutgoingPacketSize]);
   size_t length = framer_->BuildPathResponsePacket(
       header, buffer.get(), max_plaintext_size_, payloads, is_padded,