commit 050d2d4c5e24687940a4be92ee82f4903a1a9538
author wub <wub@google.com> Mon Jun 22 14:45:27 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Jun 22 14:46:06 2020 -0700
tree 7d8ce2b8dc19d901c8d03258e02424e5cf772549
parent 691303b60a74a7398b580430a194ba63515e8db3

For quic loss detection, replace quicconnectionstats.total_loss_detection_time by quicconnectionstats. total_loss_detection_response_time to improve the accuracy of detection speed. protected by existing --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe.

On skmobile-cjj5 this reduced the threshold value from 8 to 4.5: http://shortn/_vT0AbUjKU6. shift value did not change.

PiperOrigin-RevId: 317739228
Change-Id: I091fabc50753c754c9377d79f7b5a77878d8fbc8

quic/core/quic_sent_packet_manager.cc

diff --git a/quic/core/quic_sent_packet_manager.cc b/quic/core/quic_sent_packet_manager.cc
index 86628ef..4373013 100644
--- a/quic/core/quic_sent_packet_manager.cc
+++ b/quic/core/quic_sent_packet_manager.cc
@@ -978,14 +978,13 @@
   stats_->sent_packets_num_borderline_time_reorderings +=
       detection_stats.sent_packets_num_borderline_time_reorderings;
 
+  stats_->total_loss_detection_response_time +=
+      detection_stats.total_loss_detection_response_time;
+
   for (const LostPacket& packet : packets_lost_) {
     QuicTransmissionInfo* info =
         unacked_packets_.GetMutableTransmissionInfo(packet.packet_number);
     ++stats_->packets_lost;
-    if (time > info->sent_time) {
-      stats_->total_loss_detection_time =
-          stats_->total_loss_detection_time + (time - info->sent_time);
-    }
     if (debug_delegate_ != nullptr) {
       debug_delegate_->OnPacketLoss(packet.packet_number,
                                     info->encryption_level, LOSS_RETRANSMISSION,