| commit | 003094a4b111ce922a71e109537577ed682a04f8 | [log] [tgz] |
|---|---|---|
| author | vasilvv <vasilvv@google.com> | Mon Apr 07 11:17:41 2025 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Apr 07 11:18:40 2025 -0700 |
| tree | 322cfcbba3daab4d964eff7965b7e1c7b7ccde95 | |
| parent | 57ec3567eab1a8b4feac14cbd3af0e28d4e230f7 [diff] |
Make MoqtControlParser read directly from the stream, similar to what MoqtDataParser already does. The immediate cause for this is a recurring (but very difficult to isolate bug) in which something like this happens: 1. Parser receives a control frame. 2. The application visitor does not like the contents of the frame, so it terminates the connection. 3. MoqtSession closes the underlying WebTransport session, which results in the control stream being reset. 4. Control stream being reset results in the receive buffer being deleted. 5. When the visitor returns, the parser attempts to parse the next chunk, not realizing that the buffer in question has been deleted. I spent some time trying to come up with a workaround, but none of them seemed to work, so I gave up and just rewrote the thing to call the stream directly; that way, if the stream drops its buffers, the read will just fail. (this CL does not have a repro for this bug, since triggering it consistently turns out to be really hard due to the way parser does its own buffering; a downstream CL has an ASAN crash that triggers it, and I've also randomly hit it in the integration tests before) As a side effect, I also made the parser automatically fail on any FIN on the control stream (we used to handle those at message boundaries, which is not necessary). PiperOrigin-RevId: 744787214
QUICHE stands for QUIC, Http, Etc. It is Google‘s production-ready implementation of QUIC, HTTP/2, HTTP/3, and related protocols and tools. It powers Google’s servers, Chromium, Envoy, and other projects. It is actively developed and maintained.
There are two public QUICHE repositories. Either one may be used by embedders, as they are automatically kept in sync:
To embed QUICHE in your project, platform APIs need to be implemented and build files need to be created. Note that it is on the QUICHE team's roadmap to include default implementation for all platform APIs and to open-source build files. In the meanwhile, take a look at open source embedders like Chromium and Envoy to get started:
To contribute to QUICHE, follow instructions at CONTRIBUTING.md.
QUICHE is only supported on little-endian platforms.