commit fde3ee08937c109d0ec28ffc7591f35fae2d8eff
author wub <wub@google.com> Wed Feb 19 06:53:09 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Feb 19 06:53:56 2020 -0800
tree 805f4cee6f966496bd18ec2b2bff8e700d6ab1a4
parent 3e6b4ffc586e299ed6e4f24cdca0fe7ca4aa6bb9

gfe-relnote: (n/a) In PacketNumberIndexedQueue::RemoveUpTo, cleanup unused slots in the front before return. No behavior change, not protected.

This only changes when to cleanup leading unused slots in the queue, from the caller's perspective, the content of the queue stays the same.

PiperOrigin-RevId: 295958238
Change-Id: I2dd30f18d5da1a20c58317e4d6a120dc45c99be7

quic/core/packet_number_indexed_queue_test.cc

diff --git a/quic/core/packet_number_indexed_queue_test.cc b/quic/core/packet_number_indexed_queue_test.cc
index e23df99..5f6b09c 100644
--- a/quic/core/packet_number_indexed_queue_test.cc
+++ b/quic/core/packet_number_indexed_queue_test.cc
@@ -178,8 +178,10 @@
   EXPECT_EQ(QuicPacketNumber(1001u), queue_.first_packet());
   EXPECT_EQ(2u, queue_.number_of_present_entries());
 
+  // Remove up to 1100, since [1100, 2001) are !present, they should be cleaned
+  // up from the front.
   queue_.RemoveUpTo(QuicPacketNumber(1100));
-  EXPECT_EQ(QuicPacketNumber(1100u), queue_.first_packet());
+  EXPECT_EQ(QuicPacketNumber(2001u), queue_.first_packet());
   EXPECT_EQ(1u, queue_.number_of_present_entries());
 
   queue_.RemoveUpTo(QuicPacketNumber(2001));