commit f4f4712d642647e0e0c9a1aeb32cfef9cea9a4bf
author renjietang <renjietang@google.com> Mon Jul 22 12:08:53 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Jul 23 06:47:15 2019 -0700
tree 54291964ecb8a23a26a69b45609e1e17326dbbf6
parent 89e73569632ced2a66ad01e9cf7f5160caadaeae

Modify push_promise related methods to prepare for H3 push promise.

WritePushPromise() now returns void as no caller uses the returned size.
OnPushPromiseFrameStart() now takes in the frame lengths so that the frame can be consumed properly.

gfe-relnote: no prod behavior change, not protected.
PiperOrigin-RevId: 259377914
Change-Id: Ic89cdd785acf216e7fa5715426bbac30bf9b6045

quic/core/http/quic_spdy_session.cc

diff --git a/quic/core/http/quic_spdy_session.cc b/quic/core/http/quic_spdy_session.cc
index 8bbe7a4..6f39445 100644
--- a/quic/core/http/quic_spdy_session.cc
+++ b/quic/core/http/quic_spdy_session.cc
@@ -513,12 +513,12 @@
   send_control_stream_->WritePriority(priority);
 }
 
-size_t QuicSpdySession::WritePushPromise(QuicStreamId original_stream_id,
-                                         QuicStreamId promised_stream_id,
-                                         SpdyHeaderBlock headers) {
+void QuicSpdySession::WritePushPromise(QuicStreamId original_stream_id,
+                                       QuicStreamId promised_stream_id,
+                                       SpdyHeaderBlock headers) {
   if (perspective() == Perspective::IS_CLIENT) {
     QUIC_BUG << "Client shouldn't send PUSH_PROMISE";
-    return 0;
+    return;
   }
 
   SpdyPushPromiseIR push_promise(original_stream_id, promised_stream_id,
@@ -530,7 +530,6 @@
   SpdySerializedFrame frame(spdy_framer_.SerializeFrame(push_promise));
   headers_stream()->WriteOrBufferData(
       QuicStringPiece(frame.data(), frame.size()), false, nullptr);
-  return frame.size();
 }
 
 void QuicSpdySession::SendMaxHeaderListSize(size_t value) {