Add QUIC_EXPORT_PRIVATE to prepare for presubmit
A subsequent CL (cl/276207410) will add a presubmit to mitigate QUICHE merge issues, this CL gets our code-base to a state of compliance with that presubmit. These haven't caused issues in Chromium if they were only used in the same build unit, but it's worth it to have a consistent use across the codebase to make sure everything works in Chromium.
gfe-relnote: no behavior change, QUIC_EXPORT_PRIVATE is a no-op in google3
PiperOrigin-RevId: 276276729
Change-Id: I67ab8c9df92d24d0006de7084ca563153f0bf07f
diff --git a/quic/core/qpack/offline/qpack_offline_decoder.h b/quic/core/qpack/offline/qpack_offline_decoder.h
index c12c491..ecaebc8 100644
--- a/quic/core/qpack/offline/qpack_offline_decoder.h
+++ b/quic/core/qpack/offline/qpack_offline_decoder.h
@@ -19,7 +19,8 @@
// a list of expected header lists read from another file. File format is
// described at
// https://github.com/quicwg/base-drafts/wiki/QPACK-Offline-Interop.
-class QpackOfflineDecoder : public QpackDecoder::EncoderStreamErrorDelegate {
+class QUIC_EXPORT_PRIVATE QpackOfflineDecoder
+ : public QpackDecoder::EncoderStreamErrorDelegate {
public:
QpackOfflineDecoder();
~QpackOfflineDecoder() override = default;
@@ -39,7 +40,7 @@
// Data structure to hold TestHeadersHandler and QpackProgressiveDecoder until
// decoding of a header header block (and all preceding header blocks) is
// complete.
- struct Decoder {
+ struct QUIC_EXPORT_PRIVATE Decoder {
std::unique_ptr<test::TestHeadersHandler> headers_handler;
std::unique_ptr<QpackProgressiveDecoder> progressive_decoder;
uint64_t stream_id;
diff --git a/quic/core/qpack/qpack_decoded_headers_accumulator.h b/quic/core/qpack/qpack_decoded_headers_accumulator.h
index c649322..93c5621 100644
--- a/quic/core/qpack/qpack_decoded_headers_accumulator.h
+++ b/quic/core/qpack/qpack_decoded_headers_accumulator.h
@@ -37,7 +37,7 @@
// Visitor interface used for blocked decoding. Exactly one visitor method
// will be called if EndHeaderBlock() returned kBlocked. No visitor method
// will be called if EndHeaderBlock() returned any other value.
- class Visitor {
+ class QUIC_EXPORT_PRIVATE Visitor {
public:
virtual ~Visitor() = default;
diff --git a/quic/core/qpack/qpack_decoder_stream_receiver.h b/quic/core/qpack/qpack_decoder_stream_receiver.h
index 6071939..396c6df 100644
--- a/quic/core/qpack/qpack_decoder_stream_receiver.h
+++ b/quic/core/qpack/qpack_decoder_stream_receiver.h
@@ -23,7 +23,7 @@
public:
// An interface for handling instructions decoded from the decoder stream, see
// https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.5.3
- class Delegate {
+ class QUIC_EXPORT_PRIVATE Delegate {
public:
virtual ~Delegate() = default;
diff --git a/quic/core/qpack/qpack_encoder.h b/quic/core/qpack/qpack_encoder.h
index 1ed56a8..22232e6 100644
--- a/quic/core/qpack/qpack_encoder.h
+++ b/quic/core/qpack/qpack_encoder.h
@@ -95,7 +95,7 @@
// changing QpackInstructionEncoder::Encoder() to take an
// InstructionWithValues struct instead of separate |instruction| and |values|
// arguments.
- struct InstructionWithValues {
+ struct QUIC_EXPORT_PRIVATE InstructionWithValues {
// |instruction| is not owned.
const QpackInstruction* instruction;
QpackInstructionEncoder::Values values;
diff --git a/quic/core/qpack/qpack_encoder_stream_receiver.h b/quic/core/qpack/qpack_encoder_stream_receiver.h
index 8da3147..b393b54 100644
--- a/quic/core/qpack/qpack_encoder_stream_receiver.h
+++ b/quic/core/qpack/qpack_encoder_stream_receiver.h
@@ -22,7 +22,7 @@
public:
// An interface for handling instructions decoded from the encoder stream, see
// https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.5.2
- class Delegate {
+ class QUIC_EXPORT_PRIVATE Delegate {
public:
virtual ~Delegate() = default;
diff --git a/quic/core/qpack/qpack_header_table.h b/quic/core/qpack/qpack_header_table.h
index 78d85f6..d2650e5 100644
--- a/quic/core/qpack/qpack_header_table.h
+++ b/quic/core/qpack/qpack_header_table.h
@@ -40,7 +40,7 @@
enum class MatchType { kNameAndValue, kName, kNoMatch };
// Observer interface for dynamic table insertion.
- class Observer {
+ class QUIC_EXPORT_PRIVATE Observer {
public:
virtual ~Observer() = default;
diff --git a/quic/core/qpack/qpack_instruction_encoder.h b/quic/core/qpack/qpack_instruction_encoder.h
index 1ca52e6..4f1392a 100644
--- a/quic/core/qpack/qpack_instruction_encoder.h
+++ b/quic/core/qpack/qpack_instruction_encoder.h
@@ -21,7 +21,7 @@
public:
// Storage for field values to be encoded.
// The encoded instruction determines which values are actually used.
- struct Values {
+ struct QUIC_EXPORT_PRIVATE Values {
bool s_bit;
uint64_t varint;
uint64_t varint2;
diff --git a/quic/core/qpack/qpack_test_utils.h b/quic/core/qpack/qpack_test_utils.h
index 42fa383..7011e88 100644
--- a/quic/core/qpack/qpack_test_utils.h
+++ b/quic/core/qpack/qpack_test_utils.h
@@ -27,7 +27,8 @@
FragmentMode fragment_mode);
// Mock QpackUnidirectionalStreamSenderDelegate implementation.
-class MockQpackStreamSenderDelegate : public QpackStreamSenderDelegate {
+class QUIC_EXPORT_PRIVATE MockQpackStreamSenderDelegate
+ : public QpackStreamSenderDelegate {
public:
~MockQpackStreamSenderDelegate() override = default;
