commit f00e1e10185aa6fbaa383defe80cb92acd62a86c
author renjietang <renjietang@google.com> Wed Aug 26 10:51:15 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Aug 26 10:52:01 2020 -0700
tree bced1bccfbe7bb37f6268c07e45e2930328d6da8
parent f4cb78ca889e43d15970510b86637282b234de5a

Deprecate QuicSession::CloseStream().

Unused code. not protected.

PiperOrigin-RevId: 328563383
Change-Id: I0f867cadeb149137175f07574d7ddc7947e164aa

quic/core/quic_stream.h

diff --git a/quic/core/quic_stream.h b/quic/core/quic_stream.h
index 3590190..68d3f89 100644
--- a/quic/core/quic_stream.h
+++ b/quic/core/quic_stream.h
@@ -349,19 +349,6 @@
   // gracefully.
   virtual bool OnStopSending(uint16_t code);
 
-  // Close the write side of the socket.  Further writes will fail.
-  // Can be called by the subclass or internally.
-  // Does not send a FIN.  May cause the stream to be closed.
-  virtual void CloseWriteSide();
-
-  // Close the read side of the stream.  May cause the stream to be closed.
-  // Subclasses and consumers should use StopReading to terminate reading early
-  // if expecting a FIN. Can be used directly by subclasses if not expecting a
-  // FIN.
-  // TODO(fayang): move this to protected when removing
-  // QuicSession::CloseStream.
-  void CloseReadSide();
-
   // Returns true if the stream is static.
   bool is_static() const { return is_static_; }
 
@@ -414,6 +401,11 @@
   // empty.
   void SetFinSent();
 
+  // Close the write side of the socket.  Further writes will fail.
+  // Can be called by the subclass or internally.
+  // Does not send a FIN.  May cause the stream to be closed.
+  virtual void CloseWriteSide();
+
   void set_rst_received(bool rst_received) { rst_received_ = rst_received; }
   void set_stream_error(QuicRstStreamErrorCode error) { stream_error_ = error; }
 
@@ -461,6 +453,9 @@
   // WriteOrBufferData, Writev and WriteBufferedData.
   void WriteBufferedData();
 
+  // Close the read side of the stream.  May cause the stream to be closed.
+  void CloseReadSide();
+
   // Called when bytes are sent to the peer.
   void AddBytesSent(QuicByteCount bytes);