commit eff02bb1654dfd416f8f0be5d63d8ad602e56c19
author zhongyi <zhongyi@google.com> Fri Dec 13 14:38:48 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Dec 13 14:39:22 2019 -0800
tree 10dd0252c0fc9615dde018aea5d29e5c643a667a
parent 98b7ef099805833bbb084e9ebacfdcfd37be1f58

Load QUIC build config in spdy/core/hpack/BUILD, spdy/platform/api/BUILD and spdy/platform/impl/BUILD.

This CL helps align the google3 spdy core build with Chromium, which prevents quiche merge issues.

All non-trivial changes are found by enabling this build config: unused parameters, inconsistent param names between .h and .cc files.

gfe-relnote: n/a, build-only change.
PiperOrigin-RevId: 285474166
Change-Id: I11669af285ee1b7d3d07750ac19cc8668908153a

spdy/core/hpack/hpack_decoder_adapter.cc

diff --git a/spdy/core/hpack/hpack_decoder_adapter.cc b/spdy/core/hpack/hpack_decoder_adapter.cc
index 278eaab..b3bce70 100644
--- a/spdy/core/hpack/hpack_decoder_adapter.cc
+++ b/spdy/core/hpack/hpack_decoder_adapter.cc
@@ -10,7 +10,6 @@
 #include "net/third_party/quiche/src/spdy/platform/api/spdy_logging.h"
 
 using ::http2::DecodeBuffer;
-using ::http2::HpackEntryType;
 using ::http2::HpackString;
 
 namespace spdy {
@@ -146,8 +145,7 @@
   }
 }
 
-void HpackDecoderAdapter::ListenerAdapter::OnHeader(HpackEntryType entry_type,
-                                                    const HpackString& name,
+void HpackDecoderAdapter::ListenerAdapter::OnHeader(const HpackString& name,
                                                     const HpackString& value) {
   SPDY_DVLOG(2) << "HpackDecoderAdapter::ListenerAdapter::OnHeader:\n name: "
                 << name << "\n value: " << value;
@@ -178,16 +176,17 @@
 }
 
 int64_t HpackDecoderAdapter::ListenerAdapter::OnEntryInserted(
-    const http2::HpackStringPair& sp,
+    const http2::HpackStringPair& entry,
     size_t insert_count) {
   SPDY_DVLOG(2) << "HpackDecoderAdapter::ListenerAdapter::OnEntryInserted: "
-                << sp << ",  insert_count=" << insert_count;
+                << entry << ",  insert_count=" << insert_count;
   if (visitor_ == nullptr) {
     return 0;
   }
-  HpackEntry entry(sp.name.ToStringPiece(), sp.value.ToStringPiece(),
-                   /*is_static*/ false, insert_count);
-  int64_t time_added = visitor_->OnNewEntry(entry);
+  HpackEntry hpack_entry(entry.name.ToStringPiece(),
+                         entry.value.ToStringPiece(),
+                         /*is_static*/ false, insert_count);
+  int64_t time_added = visitor_->OnNewEntry(hpack_entry);
   SPDY_DVLOG(2)
       << "HpackDecoderAdapter::ListenerAdapter::OnEntryInserted: time_added="
       << time_added;
@@ -195,17 +194,18 @@
 }
 
 void HpackDecoderAdapter::ListenerAdapter::OnUseEntry(
-    const http2::HpackStringPair& sp,
+    const http2::HpackStringPair& entry,
     size_t insert_count,
     int64_t time_added) {
-  SPDY_DVLOG(2) << "HpackDecoderAdapter::ListenerAdapter::OnUseEntry: " << sp
+  SPDY_DVLOG(2) << "HpackDecoderAdapter::ListenerAdapter::OnUseEntry: " << entry
                 << ",  insert_count=" << insert_count
                 << ",  time_added=" << time_added;
   if (visitor_ != nullptr) {
-    HpackEntry entry(sp.name.ToStringPiece(), sp.value.ToStringPiece(),
-                     /*is_static*/ false, insert_count);
-    entry.set_time_added(time_added);
-    visitor_->OnUseEntry(entry);
+    HpackEntry hpack_entry(entry.name.ToStringPiece(),
+                           entry.value.ToStringPiece(), /*is_static*/ false,
+                           insert_count);
+    hpack_entry.set_time_added(time_added);
+    visitor_->OnUseEntry(hpack_entry);
   }
 }