Remove two obsolete TODOs from http_decoder.cc. Remove TODO for incremental parsing of PRIORITY frames because PRIORITY frames have a very limited maximum size and it seems quite silly to change Visitor interface to handle PRIORITY frames field-by-field. Remove TODO for incremental parsing of SETTINGS frames because it is not worth the complexity. See prototype at cr/264362665. gfe-relnote: n/a, change to comments only. PiperOrigin-RevId: 264628766 Change-Id: I1a4006549f591d25c6614322b13ee96262d2d83b
diff --git a/quic/core/http/http_decoder.cc b/quic/core/http/http_decoder.cc index 3a13300..78f8539 100644 --- a/quic/core/http/http_decoder.cc +++ b/quic/core/http/http_decoder.cc
@@ -520,7 +520,6 @@ // TODO(bnc): Close connection with HTTP_MALFORMED_FRAME // if lowest three bits are not all zero. - // TODO(b/137359636): Handle partial delivery. if (frame->prioritized_type != ROOT_OF_TREE && !reader->ReadVarInt62(&frame->prioritized_element_id)) { // TODO(b/124216424): Use HTTP_MALFORMED_FRAME. @@ -552,7 +551,6 @@ bool HttpDecoder::ParseSettingsFrame(QuicDataReader* reader, SettingsFrame* frame) { while (!reader->IsDoneReading()) { - // TODO(bnc): Handle partial delivery of both fields. uint64_t id; if (!reader->ReadVarInt62(&id)) { // TODO(b/124216424): Use HTTP_MALFORMED_FRAME.