commit e3d0e35c1b34cf3436511f4c5967092e3e193735
author QUICHE team <quiche-dev@google.com> Thu May 22 13:41:36 2025 -0700
committer Copybara-Service <copybara-worker@google.com> Thu May 22 13:42:33 2025 -0700
tree 02075744316622fb42a47237778ab4c37e4056ed
parent f7fef77243a764c37f736f43c19bdb25964448b3

Declare header_properties static arrays as constexpr.

This ultra-super-duper avoids construction at runtime.

PiperOrigin-RevId: 762107687

quiche/balsa/header_properties.cc

diff --git a/quiche/balsa/header_properties.cc b/quiche/balsa/header_properties.cc
index 1022ed0..17115b4 100644
--- a/quiche/balsa/header_properties.cc
+++ b/quiche/balsa/header_properties.cc
@@ -139,21 +139,21 @@
 }
 
 bool IsInvalidHeaderKeyChar(uint8_t c) {
-  static const std::array<bool, 256> invalidHeaderKeyCharTable =
+  static constexpr std::array<bool, 256> invalidHeaderKeyCharTable =
       buildInvalidHeaderKeyCharLookupTable();
 
   return invalidHeaderKeyCharTable[c];
 }
 
 bool IsInvalidHeaderKeyCharAllowDoubleQuote(uint8_t c) {
-  static const std::array<bool, 256> invalidHeaderKeyCharTable =
+  static constexpr std::array<bool, 256> invalidHeaderKeyCharTable =
       buildInvalidHeaderKeyCharLookupTableAllowDoubleQuote();
 
   return invalidHeaderKeyCharTable[c];
 }
 
 bool IsInvalidHeaderChar(uint8_t c) {
-  static const std::array<bool, 256> invalidCharTable =
+  static constexpr std::array<bool, 256> invalidCharTable =
       buildInvalidCharLookupTable();
 
   return invalidCharTable[c];
@@ -169,7 +169,7 @@
 }
 
 bool HasInvalidPathChar(absl::string_view value) {
-  static const std::array<bool, 256> invalidCharTable =
+  static constexpr std::array<bool, 256> invalidCharTable =
       buildInvalidPathCharLookupTable();
   for (const char c : value) {
     if (invalidCharTable[c]) {
@@ -180,7 +180,7 @@
 }
 
 bool HasInvalidQueryChar(absl::string_view value) {
-  static const std::array<bool, 256> invalidCharTable =
+  static constexpr std::array<bool, 256> invalidCharTable =
       buildInvalidQueryCharLookupTable();
   for (const char c : value) {
     if (invalidCharTable[c]) {