commit dde2a1e7bca2ea11dae8e5d5fe1d56a13e1f13ca
author ianswett <ianswett@google.com> Tue Dec 10 10:39:44 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Dec 10 10:40:19 2019 -0800
tree 5fba37ad73f5ea4182915a04b1eaa083f3890994
parent 6d295789cb750e1f0804dec8af002ac8d728bd46

gfe-relnote: Remove num_expected_static_streams_ from QuicStreamIdManager.  Protected by disabled flags quic_enable_version_q099 and quic_enable_version_t099.

PiperOrigin-RevId: 284800705
Change-Id: I59704833d2030bf477f47d11de0fd9826dd15e27

quic/core/quic_session.cc

diff --git a/quic/core/quic_session.cc b/quic/core/quic_session.cc
index 2b50ebc..60fea01 100644
--- a/quic/core/quic_session.cc
+++ b/quic/core/quic_session.cc
@@ -67,7 +67,6 @@
           perspective(),
           connection->version(),
           this,
-          num_expected_unidirectional_static_streams,
           kDefaultMaxStreamsPerConnection,
           kDefaultMaxStreamsPerConnection,
           config_.GetMaxIncomingBidirectionalStreamsToSend(),
@@ -999,6 +998,15 @@
     if (config_.HasReceivedMaxIncomingUnidirectionalStreams()) {
       max_streams = config_.ReceivedMaxIncomingUnidirectionalStreams();
     }
+    if (max_streams < num_expected_unidirectional_static_streams_) {
+      // TODO(ianswett): Change this to an application error for HTTP/3.
+      QUIC_DLOG(ERROR) << "Received unidirectional stream limit of "
+                       << max_streams << " < "
+                       << num_expected_unidirectional_static_streams_;
+      connection_->CloseConnection(
+          QUIC_MAX_STREAMS_ERROR, "New unidirectional stream limit is too low.",
+          ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
+    }
     QUIC_DVLOG(1) << ENDPOINT
                   << "Setting Unidirectional outgoing_max_streams_ to "
                   << max_streams;