commit db06153cd17bd3e2d8796ff6a6be1738813d2751
author QUICHE team <quiche-dev@google.com> Sat Mar 23 18:23:05 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Sat Mar 23 18:23:38 2019 -0700
tree 2d6e844a2c0dbe7ac405e46a6ca6f6d5e43d1292
parent 552f71f50ce78c5330d0dee59a9259de73ae2cf9

Add a QUIC_BUG to ensure that whenever an ACK cannot be written, the writer is write blocked.  Protected by existing flag gfe2_reloadable_flag_quic_use_uber_loss_algorithm.

gfe-relnote: n/a (Add a QUIC_BUG)
PiperOrigin-RevId: 239981503
Change-Id: Ic53a7e7ff8abecc9284edd6b9a6acb5b335dbb4d

quic/core/quic_connection.cc

diff --git a/quic/core/quic_connection.cc b/quic/core/quic_connection.cc
index cdfef6f..c27d1cb 100644
--- a/quic/core/quic_connection.cc
+++ b/quic/core/quic_connection.cc
@@ -3941,6 +3941,8 @@
     const bool flushed = packet_generator_.FlushAckFrame(frames);
     if (!flushed) {
       // Connection is write blocked.
+      QUIC_BUG_IF(!writer_->IsWriteBlocked())
+          << "Writer not blocked, but ACK not flushed for packet space:" << i;
       break;
     }
     ResetAckStates();