Prevent crash when trying to serialize packet with missing encryption key
b/151452116 shows GFE crashing in QuicFramer due to dereferencing a null pointer. This CL adds checks for this and triggers a QUIC_BUG instead of crashing. Our goal is to have the issue reproduce with the QUIC_BUG so we can investigate further what's causing us to get into that state.
gfe-relnote: replace crash with GFE_BUG, not flag-protected
PiperOrigin-RevId: 301250535
Change-Id: I4e88a9de2cec50867fd4c166a3688147670dd264
diff --git a/quic/core/quic_packet_creator.cc b/quic/core/quic_packet_creator.cc
index 923b219..cea1a1b 100644
--- a/quic/core/quic_packet_creator.cc
+++ b/quic/core/quic_packet_creator.cc
@@ -679,6 +679,15 @@
<< QuicFramesToString(queued_frames_) << " at encryption_level "
<< EncryptionLevelToString(packet_.encryption_level);
+ if (!framer_->HasEncrypterOfEncryptionLevel(packet_.encryption_level)) {
+ QUIC_BUG << ENDPOINT << "Attempting to serialize " << header
+ << QuicFramesToString(queued_frames_)
+ << " at missing encryption_level "
+ << EncryptionLevelToString(packet_.encryption_level) << " using "
+ << framer_->version();
+ return;
+ }
+
DCHECK_GE(max_plaintext_size_, packet_size_);
// Use the packet_size_ instead of the buffer size to ensure smaller
// packet sizes are properly used.
