Google Git
Sign in
quiche / quiche.git / da9fafd2d94f51a79adcdda07157e7b477df2161
commitda9fafd2d94f51a79adcdda07157e7b477df2161[log] [tgz]
authordschinazi <dschinazi@google.com>Mon Mar 16 15:32:55 2020 -0700
committerCopybara-Service <copybara-worker@google.com>Mon Mar 16 15:33:32 2020 -0700
tree70cf16995a9151b6ca66494572fa1f77989181e3
parentc30a40adf36f5d3b53b6c451ae1637780b9d940d [diff]
Prevent crash when trying to serialize packet with missing encryption key

b/151452116 shows GFE crashing in QuicFramer due to dereferencing a null pointer. This CL adds checks for this and triggers a QUIC_BUG instead of crashing. Our goal is to have the issue reproduce with the QUIC_BUG so we can investigate further what's causing us to get into that state.

gfe-relnote: replace crash with GFE_BUG, not flag-protected
PiperOrigin-RevId: 301250535
Change-Id: I4e88a9de2cec50867fd4c166a3688147670dd264
2 files changed
tree: 70cf16995a9151b6ca66494572fa1f77989181e3
  1. common/
  2. epoll_server/
  3. http2/
  4. quic/
  5. spdy/
  6. CONTRIBUTING.md
  7. LICENSE
  8. README.md
README.md

QUICHE

QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects.