commit d5c4a93c45184e0d4758b42029bf16811d7a618a
author nharper <nharper@google.com> Mon May 13 13:58:49 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue May 14 06:33:13 2019 -0700
tree 062d796a3425fe3f147d9d19ccfaddc1bc95c8bd
parent 51961cfa1aa9797ab52c6a5b975e592139c9f8ae

Don't use a flow controller for QuicCryptoStream when it uses CRYPTO frames

gfe-relnote: QuicCryptoStream change protected behind QUIC_VERSION_99
PiperOrigin-RevId: 248004335
Change-Id: I97d5b6ed0e5523a4264ce2f06e5f6c3249a99fe9

quic/core/quic_stream.h

diff --git a/quic/core/quic_stream.h b/quic/core/quic_stream.h
index b6d03de..df1f7f8 100644
--- a/quic/core/quic_stream.h
+++ b/quic/core/quic_stream.h
@@ -30,6 +30,7 @@
 #include "net/third_party/quiche/src/quic/core/session_notifier_interface.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_export.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_mem_slice_span.h"
+#include "net/third_party/quiche/src/quic/platform/api/quic_optional.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_reference_counted.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_string_piece.h"
 #include "net/third_party/quiche/src/spdy/core/spdy_protocol.h"
@@ -224,7 +225,7 @@
   int num_frames_received() const;
   int num_duplicate_frames_received() const;
 
-  QuicFlowController* flow_controller() { return &flow_controller_; }
+  QuicFlowController* flow_controller() { return &*flow_controller_; }
 
   // Called when endpoint receives a frame which could increase the highest
   // offset.
@@ -433,7 +434,7 @@
              StreamType type,
              uint64_t stream_bytes_read,
              bool fin_received,
-             QuicFlowController flow_controller,
+             QuicOptional<QuicFlowController> flow_controller,
              QuicFlowController* connection_flow_controller);
 
   // Subclasses and consumers should use reading_stopped.
@@ -504,7 +505,7 @@
   // server or a client.
   Perspective perspective_;
 
-  QuicFlowController flow_controller_;
+  QuicOptional<QuicFlowController> flow_controller_;
 
   // The connection level flow controller. Not owned.
   QuicFlowController* connection_flow_controller_;