commit d322ca721562d957e47e36fe855720a4a7217db3
author nharper <nharper@google.com> Mon Apr 27 11:57:00 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Apr 27 11:57:33 2020 -0700
tree a73c94338bb09dff402f780c7fb8d05d413a4620
parent f8623ccdd8186e198633c6c56bd6aab7b3f54796

Implement a TicketCrypter in ProofSourceGoogle3

gfe-relnote: Plumb support for QUIC-TLS session resumption, protected by quic_enable_tls_resumption
PiperOrigin-RevId: 308668324
Change-Id: Ib404e09df245f5eabe95437c7243f0caefa6ca66

quic/core/http/quic_spdy_client_session_test.cc

diff --git a/quic/core/http/quic_spdy_client_session_test.cc b/quic/core/http/quic_spdy_client_session_test.cc
index eea081c..ce0cf9f 100644
--- a/quic/core/http/quic_spdy_client_session_test.cc
+++ b/quic/core/http/quic_spdy_client_session_test.cc
@@ -171,11 +171,9 @@
     } else {
       config.SetMaxBidirectionalStreamsToSend(server_max_incoming_streams);
     }
+    SetQuicReloadableFlag(quic_enable_tls_resumption, true);
     std::unique_ptr<QuicCryptoServerConfig> crypto_config =
         crypto_test_utils::CryptoServerConfigForTesting();
-    if (connection_->version().handshake_protocol == PROTOCOL_TLS1_3) {
-      SSL_CTX_clear_options(crypto_config->ssl_ctx(), SSL_OP_NO_TICKET);
-    }
     crypto_test_utils::HandshakeWithFakeServer(
         &config, crypto_config.get(), &helper_, &alarm_factory_, connection_,
         stream, AlpnForVersion(connection_->version()));

quic/core/tls_client_handshaker_test.cc

diff --git a/quic/core/tls_client_handshaker_test.cc b/quic/core/tls_client_handshaker_test.cc
index 2ba2d91..0ba517f 100644
--- a/quic/core/tls_client_handshaker_test.cc
+++ b/quic/core/tls_client_handshaker_test.cc
@@ -164,10 +164,10 @@
         crypto_config_(std::make_unique<QuicCryptoClientConfig>(
             std::make_unique<TestProofVerifier>(),
             std::make_unique<test::SimpleSessionCache>())),
-        server_crypto_config_(
-            crypto_test_utils::CryptoServerConfigForTesting()),
         server_compressed_certs_cache_(
             QuicCompressedCertsCache::kQuicCompressedCertsCacheSize) {
+    SetQuicReloadableFlag(quic_enable_tls_resumption, true);
+    server_crypto_config_ = crypto_test_utils::CryptoServerConfigForTesting();
     CreateConnection();
   }
 
@@ -317,9 +317,6 @@
 }
 
 TEST_P(TlsClientHandshakerTest, Resumption) {
-  // Enable resumption on the server:
-  SSL_CTX_clear_options(server_crypto_config_->ssl_ctx(), SSL_OP_NO_TICKET);
-
   // Finish establishing the first connection:
   CompleteCryptoHandshake();