commit d1967a23b1bd5f7e591573a4ec2c4bb5af842546
author dschinazi <dschinazi@google.com> Wed Apr 03 16:11:32 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Apr 04 09:13:52 2019 -0700
tree 2245d2e15ce08d764aa174882d87037ddf8c9a84
parent 00f47df999c9b19e80fdc01db0ae9ca1b6a12b3a

Gracefully handle missing Google-specific transport parameters when using TLS

This CL also adds a few DCHECKs that helped find this issue.

gfe-relnote: specific to QUIC versions that use TLS which are disabled by flag quic_supports_tls_handshake
PiperOrigin-RevId: 241826266
Change-Id: I4baa70e8f02deafa7148a94df45f96852913de7e

quic/core/tls_client_handshaker.cc

diff --git a/quic/core/tls_client_handshaker.cc b/quic/core/tls_client_handshaker.cc
index a5116ee..adc2c81 100644
--- a/quic/core/tls_client_handshaker.cc
+++ b/quic/core/tls_client_handshaker.cc
@@ -140,6 +140,7 @@
           error_details) != QUIC_NO_ERROR ||
       session()->config()->ProcessTransportParameters(
           params, SERVER, error_details) != QUIC_NO_ERROR) {
+    DCHECK(!error_details->empty());
     return false;
   }
 
@@ -231,6 +232,7 @@
 
 void TlsClientHandshaker::CloseConnection(QuicErrorCode error,
                                           const std::string& reason_phrase) {
+  DCHECK(!reason_phrase.empty());
   state_ = STATE_CONNECTION_CLOSED;
   stream()->CloseConnectionWithDetails(error, reason_phrase);
 }
@@ -241,6 +243,7 @@
 
   std::string error_details;
   if (!ProcessTransportParameters(&error_details)) {
+    DCHECK(!error_details.empty());
     CloseConnection(QUIC_HANDSHAKE_FAILED, error_details);
     return;
   }