Modify HTTP/2 varint encoder and decoder to support 8-bit prefixes.
This is necessary for QPACK for Largest Reference in Header Data Prefix, see
https://quicwg.org/base-drafts/draft-ietf-quic-qpack.html#rfc.section.4.5.1.
Fortunately all the logic trivially handles this case, only DCHECKs need to be
relaxed.
gfe-relnote: n/a (Relax DCHECKs in production code and modify tests.)
PiperOrigin-RevId: 225873577
Change-Id: Ib29268cff712b48bfbb93cfb130b10f58e3532ff
diff --git a/http2/hpack/varint/hpack_varint_encoder_test.cc b/http2/hpack/varint/hpack_varint_encoder_test.cc
index d230af3..a6043a0 100644
--- a/http2/hpack/varint/hpack_varint_encoder_test.cc
+++ b/http2/hpack/varint/hpack_varint_encoder_test.cc
@@ -147,10 +147,10 @@
uint64_t value;
uint8_t expected_encoding_first_byte;
} kLastByteIsZeroTestData[] = {
- {0b10110010, 1, 1, 0b10110011}, {0b10101100, 2, 3, 0b10101111},
- {0b10101000, 3, 7, 0b10101111}, {0b10110000, 4, 15, 0b10111111},
- {0b10100000, 5, 31, 0b10111111}, {0b11000000, 6, 63, 0b11111111},
- {0b10000000, 7, 127, 0b11111111}};
+ {0b10110010, 1, 1, 0b10110011}, {0b10101100, 2, 3, 0b10101111},
+ {0b10101000, 3, 7, 0b10101111}, {0b10110000, 4, 15, 0b10111111},
+ {0b10100000, 5, 31, 0b10111111}, {0b11000000, 6, 63, 0b11111111},
+ {0b10000000, 7, 127, 0b11111111}, {0b00000000, 8, 255, 0b11111111}};
// Make sure that the encoder outputs the last byte even when it is zero. This
// happens exactly when encoding the value 2^prefix_length - 1.
