gfe-relnote: Convert IETF RESET_STREAM error codes to and from QuicRstStreamErrorCode. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
IETF HTTP/3 error codes are different from Google QUIC's error codes, so some
information will be lost with IETF QUIC when translating QuicRstStreamErrorCode
to the wire and then back. Only the main category (no error, cancelled,
protocol error) is preserved.
The advantage of keeping QuicRstStreamErrorCode and adding new values for IETF
error codes is that existing APIs, most notably QuicStream::error_code(), can be
kept without need for modification. QuicStream::error_code() is almost exclusively
checked for QUIC_STREAM_NO_ERROR, QUIC_STREAM_CONNECTION_ERROR, and QUIC_STREAM_CANCELLED, the semantics of which are retained.
PiperOrigin-RevId: 306264118
Change-Id: I24f0aa810052ae42820623d5a55dfb9610db0a3c
diff --git a/quic/core/quic_framer.cc b/quic/core/quic_framer.cc
index da5d4c5..63798c3 100644
--- a/quic/core/quic_framer.cc
+++ b/quic/core/quic_framer.cc
@@ -5770,9 +5770,8 @@
return false;
}
- // TODO(b/124216424): Translate IETF error code to QuicRstStreamErrorCode.
frame->error_code =
- static_cast<QuicRstStreamErrorCode>(frame->ietf_error_code);
+ IetfResetStreamErrorCodeToRstStreamErrorCode(frame->ietf_error_code);
if (!reader->ReadVarInt62(&frame->byte_offset)) {
set_detailed_error("Unable to read rst stream sent byte offset.");
