| commit | 23346476fcb2863ac208b4e99edfd7a3aa6d3bcd | [log] [tgz] |
|---|---|---|
| author | bnc <bnc@google.com> | Thu Dec 27 21:57:05 2018 -0500 |
| committer | Victor Vasiliev <vasilvv@google.com> | Fri Dec 28 14:37:02 2018 -0500 |
| tree | abf9efb9bb4b4d19606d76d7ea9c3f00505f9807 | |
| parent | 22f96529395048f41f15744f177a93429a938b35 [diff] |
Cast to unsigned in HpackVarintRoundTripTest. Chromium's string uses unsigned char, Google3 uses signed. This causes an assertion in HpackVarintRoundTripTest to fail. This was not an issue when prefixes were only allowed to be up to 7 bits long, because then prefix_mask was at most 127. 8 bit long prefixes were allowed at cr/225873577, which was then merged to QUICHE at https://quiche.googlesource.com/quiche/+/cc66370c8f56ee74aa9f13407249a836ea26b6ce When trying to roll this into Chromium, HpackVarintRoundTripTests fail, see trybot output at https://crrev.com/c/1391715. I locally reproduced the failure in my Chromium checkout and verified that this change fixes it. PiperOrigin-RevId: 227084858 Change-Id: Ifcea92d2234d87dabba6ce82b2dac1e3a5fd90a8
QUICHE (QUIC, Http/2, Etc) is Google‘s implementation of QUIC and related protocols. It powers Chromium as well as Google’s QUIC servers and some other projects.
The code is currently in process of being moved from https://cs.chromium.org/chromium/src/net/third_party/ into this repository. Please excuse our appearance while we're under construction.